Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] Move JSON schemas to secl package #30913

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Nov 8, 2024

What does this PR do?

Move JSON schemas to SECL package.

Motivation

This allows the same JSON schemas to be shared between different repositories.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@lebauce lebauce added this to the 7.61.0 milestone Nov 8, 2024
@lebauce lebauce requested a review from a team as a code owner November 8, 2024 17:01
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Nov 8, 2024
Copy link

cit-pr-commenter bot commented Nov 8, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 084b5e90-b69f-4073-9474-fc0eb7346932

Baseline: d0a1d25
Comparison: e7b53d1
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization -8.14 [-11.83, -4.46] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.72 [-0.01, +1.46] 1 Logs
otel_to_otel_logs ingress throughput +0.38 [-0.32, +1.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.26 [-0.52, +1.05] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.15 [-0.62, +0.92] 1 Logs
quality_gate_idle_all_features memory utilization +0.15 [+0.04, +0.25] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.45, +0.47] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.10] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.85, +0.86] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.81, +0.75] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.66, +0.60] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.10 [-0.17, -0.03] 1 Logs
file_tree memory utilization -0.14 [-0.28, -0.01] 1 Logs
quality_gate_idle memory utilization -0.28 [-0.32, -0.23] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization -2.38 [-5.75, +1.00] 1 Logs
basic_py_check % cpu utilization -8.14 [-11.83, -4.46] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_1000ms_latency lost_bytes 0/10
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@lebauce lebauce force-pushed the lebauce/move-json-schema-to-secl branch from 7d751a5 to e664e9b Compare November 15, 2024 16:59
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 15, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49256032 --os-family=ubuntu

Note: This applies to commit e7b53d1

@lebauce lebauce force-pushed the lebauce/move-json-schema-to-secl branch from e664e9b to d41e2b3 Compare November 18, 2024 09:52
@lebauce lebauce force-pushed the lebauce/move-json-schema-to-secl branch from d41e2b3 to e7b53d1 Compare November 18, 2024 13:01
@lebauce
Copy link
Contributor Author

lebauce commented Nov 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-18 17:24:24 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 25m.

@dd-mergequeue dd-mergequeue bot merged commit 3387a1b into main Nov 18, 2024
223 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lebauce/move-json-schema-to-secl branch November 18, 2024 18:36
@lebauce lebauce added the qa/no-code-change No code change in Agent code requiring validation label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants