Optimize dd_bkgrnd.png #30954
Optimize dd_bkgrnd.png #30954
Conversation
blt
added
changelog/no-changelog
team/single-machine-performance
github-actions
bot
added
the
short review
|
[Fast Unit Tests Report] On pipeline 49331671 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 57d7604 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +1.09 | [-2.80, +4.98] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.92 | [+0.78, +1.07] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.68 | [-0.04, +1.40] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.63 | [-0.08, +1.34] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.49 | [-0.28, +1.26] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.28 | [-0.51, +1.06] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.22 | [-0.41, +0.85] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.11 | [-0.66, +0.88] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.11 | [+0.07, +0.15] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.10 | [-0.37, +0.57] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.09, +0.10] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.05 | [-0.91, +0.81] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.58 | [-0.64, -0.51] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.66 | [-0.76, -0.56] | 1 | Logs bounds checks dashboard |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -3.52 | [-7.00, -0.04] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_1000ms_latency | lost_bytes | 0/10 | |
| ❌ | file_to_blackhole_500ms_latency | lost_bytes | 4/10 | |
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 8/10 | |
| ❌ | file_to_blackhole_300ms_latency | lost_bytes | 8/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
Devflow running:
|
blt
force-pushed
the
blt/optimize_dd_bkgrnd_png
branch
from
3d1d9dd to
b09ddd6
Compare
|
@blt could you add on the PR description the |
Glad to. I'm on PTO but I can do so this coming Monday. |
Done. |
|
/merge |
Devflow running:
|
This commit optimizes the background png bundled into the Agent for use in its gui, running oxipng 9.1.2 on its max setting. Image size is reduced by half. Observation by @brycekahle. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/optimize_dd_bkgrnd_png
branch
from
b09ddd6 to
dc88cdb
Compare
|
/merge |
Devflow running:
|
What does this PR do?
This commit optimizes the background png bundled into the Agent for use in its gui, running oxipng 9.1.2 on its max setting. Image size is reduced by half.
Motivation
Shrink a piece of data that is present in core-agent rodata, saving some memory.
Possible Drawbacks / Trade-offs
None known.
Additional Notes
Observation by @brycekahle.
Run by me as
oxipng --opt max PATH_TO_PNG.