Add update collector version task #30955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/opentelemetry
Go Package Import DifferencesBaseline: ac888df
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: ac888df Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | pycheck_lots_of_tags | % cpu utilization | +3.74 | [+0.31, +7.18] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | +1.90 | [-1.87, +5.66] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.95 | [+0.29, +1.61] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.66 | [+0.54, +0.78] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.61 | [-0.11, +1.32] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.43 | [+0.32, +0.54] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.10 | [-0.14, +0.34] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.03 | [-0.45, +0.51] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.02 | [-0.44, +0.48] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.01 | [-0.04, +0.07] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.17, +0.19] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.02] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.11, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.01 | [-0.49, +0.48] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.36, +0.32] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.17 | [-1.24, -1.10] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_1000ms_latency | lost_bytes | 0/10 | |
| ❌ | file_to_blackhole_300ms_latency | lost_bytes | 0/10 | |
| ❌ | file_to_blackhole_500ms_latency | lost_bytes | 0/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=49152685 --os-family=ubuntuNote: This applies to commit a408a85 |
songy23
approved these changes
Nov 13, 2024
|
want to get to the bottom of why these tests are failing; I don't have any issues with the changes proposed though |
|
needs a rebase/merge |
|
Needs ddflareextension TestGetConfDump failed probably because some default config values changed |
|
there were some database issues that were pushed earlier that were rolled back since that were causing some jobs to fail as well. |
louis-cqrl
approved these changes
Nov 14, 2024
|
actually we should make sure the task updates the versions in the ocb test as well. I can make this commit if you'd like: |
Gitlab CI Configuration ChangesModified Jobsddflare_extension_ocb_build ddflare_extension_ocb_build:
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache.tar.xz
- mkdir -p /tmp/otel-ci
- cp test/otel/testdata/* /tmp/otel-ci/
- - wget -O /tmp/otel-ci/ocb https://github.com/open-telemetry/opentelemetry-collector-releases/releases/download/cmd%2Fbuilder%2Fv0.111.0/ocb_0.111.0_linux_amd64
? ^ ^
+ - wget -O /tmp/otel-ci/ocb https://github.com/open-telemetry/opentelemetry-collector-releases/releases/download/cmd%2Fbuilder%2Fv0.113.0/ocb_0.113.0_linux_amd64
? ^ ^
- chmod +x /tmp/otel-ci/ocb
image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_deps
rules:
- if: $CI_PIPELINE_SOURCE =~ /^schedule.*$/
when: never
- if: $CI_COMMIT_TAG
when: never
- if: $CI_COMMIT_MESSAGE =~ /.*\[skip cancel\].*/
when: never
- if: $CI_COMMIT_REF_NAME =~ /.*-skip-cancel$/
when: never
- when: always
script:
- echo 'Building collector with OCB and test ddflare extension'
- /tmp/otel-ci/ocb --config=/tmp/otel-ci/builder-config.yaml > ocb-output.log 2>&1
- grep -q 'Compiled' ocb-output.log || (echo "OCB failed to compile" && exit 1)
- 'grep -q ''{"binary": "/tmp/otel-ci/otelcol-custom/otelcol-custom"}'' ocb-output.log
|| (echo "OCB failed to compile" && exit 1)'
- /tmp/otel-ci/otelcol-custom/otelcol-custom --config /tmp/otel-ci/collector-config.yaml
> otelcol-custom.log 2>&1 &
- OTELCOL_PID=$!
- sleep 10
- grep -q 'Everything is ready. Begin running and processing data.' otelcol-custom.log
|| (echo "custom collector failed to start" && kill $OTELCOL_PID && exit 1)
- curl -k https://localhost:7777 > flare-info.log 2>&1
- 'grep -q ''"provided_configuration": ""'' flare-info.log || (echo "provided config
should not be supported with ocb" && kill $OTELCOL_PID && exit 1)'
- grep -q 'extensions:\\n - ddflare\\n' flare-info.log || (echo "ddflare extension
should be enabled" && kill $OTELCOL_PID && exit 1)
- kill $OTELCOL_PID
stage: integration_test
tags:
- arch:amd64docker_image_build_otel docker_image_build_otel:
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
- rm -f modcache.tar.xz
- mkdir -p /tmp/otel-ci
- cp comp/otelcol/collector-contrib/impl/manifest.yaml /tmp/otel-ci/
- cp Dockerfiles/agent-ot/Dockerfile.agent-otel /tmp/otel-ci/
- cp test/integration/docker/otel_agent_build_tests.py /tmp/otel-ci/
- wget https://github.com/mikefarah/yq/releases/download/3.4.1/yq_linux_amd64 -O
/usr/bin/yq && chmod +x /usr/bin/yq
- - export OTELCOL_VERSION=v$(/usr/bin/yq r /tmp/otel-ci/manifest.yaml dist.otelcol_version)
? --------
+ - export OTELCOL_VERSION=v$(/usr/bin/yq r /tmp/otel-ci/manifest.yaml dist.version)
- yq w -i /tmp/otel-ci/manifest.yaml "receivers[+] gomod" "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8sobjectsreceiver
${OTELCOL_VERSION}"
- yq w -i /tmp/otel-ci/manifest.yaml "processors[+] gomod" "github.com/open-telemetry/opentelemetry-collector-contrib/processor/metricstransformprocessor
${OTELCOL_VERSION}"
image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_deps
- integration_tests_otel
rules:
- if: $CI_PIPELINE_SOURCE =~ /^schedule.*$/
when: never
- if: $CI_COMMIT_TAG
when: never
- if: $CI_COMMIT_MESSAGE =~ /.*\[skip cancel\].*/
when: never
- if: $CI_COMMIT_REF_NAME =~ /.*-skip-cancel$/
when: never
- when: always
script:
- docker build --build-arg AGENT_BRANCH=$CI_COMMIT_BRANCH --tag agent-byoc:latest
-f /tmp/otel-ci/Dockerfile.agent-otel /tmp/otel-ci
- OT_AGENT_IMAGE_NAME=agent-byoc OT_AGENT_TAG=latest python3 /tmp/otel-ci/otel_agent_build_tests.py
stage: integration_test
tags:
- runner:dockerChanges Summary
ℹ️ Diff available in the job log. |
|
taking a look at why ocb ddflare build is failing, will let you know |
|
builder_config.yaml just needed an update still, pushed that change
|
ajgajg1134
approved these changes
Nov 14, 2024
purple4reina
approved these changes
Nov 14, 2024
purple4reina
approved these changes
Nov 14, 2024
jackgopack4
approved these changes
Nov 14, 2024
Co-authored-by: John L. Peterson (Jack) <john.peterson@datadoghq.com>
CelianR
approved these changes
Nov 15, 2024
Comment on lines
+281
to
+301
| url = f"https://raw.githubusercontent.com/open-telemetry/opentelemetry-collector/{version}/versions.yaml" | ||
| print(f"Fetching versions from {url}") | ||
|
|
||
| try: | ||
| response = requests.get(url) | ||
| response.raise_for_status() # Raises an HTTPError if the HTTP request returned an unsuccessful status code | ||
| except requests.exceptions.RequestException as e: | ||
| raise Exit( | ||
| color_message(f"Failed to fetch the YAML file: {e}", Color.RED), | ||
| code=1, | ||
| ) from e | ||
|
|
||
| yaml_content = response.content | ||
|
|
||
| try: | ||
| data = yaml.safe_load(yaml_content) | ||
| except yaml.YAMLError as e: | ||
| raise Exit( | ||
| color_message(f"Failed to parse YAML content: {e}", Color.RED), | ||
| code=1, | ||
| ) from e |
There was a problem hiding this comment.
💬 suggestion: You should consider using the github API instead of requests (tasks.libs.ciproviders.github_api)
There was a problem hiding this comment.
github_api only provides method download_from_url , that might be more complex than existing code
pducolin
approved these changes
Nov 15, 2024
Debug infoIf you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment. We suggest you consider adding the |
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats |
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds collector.update invoke task to update the collector version in
Running the above invoke task, we update the collector version to latest version.
After running the update task, we need to run
inv collector.generateto update contrib modules as well.Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes