Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang.org/x/time from 0.7.0 to 0.8.0 #30969

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2024

Bumps golang.org/x/time from 0.7.0 to 0.8.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Nov 11, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 11, 2024
Copy link

cit-pr-commenter bot commented Nov 11, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: febf7281-b46b-493c-b717-e1014ffab37d

Baseline: 27b1f11
Comparison: b573960
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +6.45 [+2.46, +10.45] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +6.45 [+2.46, +10.45] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.82 [-2.65, +4.30] 1 Logs
quality_gate_idle_all_features memory utilization +0.57 [+0.46, +0.68] 1 Logs bounds checks dashboard
file_tree memory utilization +0.51 [+0.39, +0.64] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.46 [-0.26, +1.18] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.30 [-0.17, +0.78] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.27 [-0.21, +0.75] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.17 [-0.07, +0.40] 1 Logs
quality_gate_idle memory utilization +0.07 [+0.03, +0.12] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.06 [-0.26, +0.37] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.47, +0.48] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.22, +0.17] 1 Logs
otel_to_otel_logs ingress throughput -0.74 [-1.42, -0.06] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.77 [-0.83, -0.71] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_100ms_latency lost_bytes 8/10
quality_gate_idle memory_usage 8/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 8/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/time-0.8.0 branch 2 times, most recently from 1768b6d to b573960 Compare November 12, 2024 14:12
@paulcacheux
Copy link
Contributor

@dependabot rebase

Bumps [golang.org/x/time](https://github.com/golang/time) from 0.7.0 to 0.8.0.
- [Commits](golang/time@v0.7.0...v0.8.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/time-0.8.0 branch from b573960 to 64e9746 Compare November 17, 2024 17:41
@paulcacheux paulcacheux added team/agent-shared-components qa/done QA done before merge and regressions are covered by tests and removed team/triage labels Nov 17, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 18, 2024

Looks like golang.org/x/time is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Nov 18, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/golang.org/x/time-0.8.0 branch November 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant