[usm] add module name to debugger #31003

guyarb · 2024-11-12T16:27:45Z

What does this PR do?

Adds module name to the debugger utilities of USM to allow filtering and distinguishing between usm entries to other modules.

Motivation

Allow other modules to easily implement their own debugging endpoints.

Filter out irrelevant entries in the blocked and traced programs output.

Describe how to test/QA your changes

UTs + manual query the debugging endpoints.

Possible Drawbacks / Trade-offs

Additional Notes

The module name will allow us to distinguish between different modules using attachers, and will allow us to provide only relevant information for the usm debugging endpoints

agent-platform-auto-pr · 2024-11-12T17:50:39Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49225304 --os-family=ubuntu

Note: This applies to commit 845f4b2

cit-pr-commenter · 2024-11-12T18:17:58Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2b90b63d-e6d9-49a4-815e-df3f7231df70

Baseline: bd393fa
Comparison: 845f4b2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.66	[+0.19, +1.12]	1	Logs
➖	file_tree	memory utilization	+0.25	[+0.12, +0.39]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.72, +0.78]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.02	[-0.61, +0.64]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.87, +0.85]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.03	[-0.13, +0.08]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.82, +0.74]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.12	[-0.85, +0.61]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.26	[-0.33, -0.18]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.36	[-1.14, +0.42]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.41	[-1.13, +0.30]	1	Logs
➖	quality_gate_idle	memory utilization	-0.50	[-0.55, -0.46]	1	Logs bounds checks dashboard
➖	basic_py_check	% cpu utilization	-0.70	[-4.48, +3.08]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.90	[-1.00, -0.80]	1	Logs bounds checks dashboard
➖	pycheck_lots_of_tags	% cpu utilization	-2.17	[-5.57, +1.23]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_1000ms_latency	lost_bytes	0/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

pkg/network/usm/utils/debugger.go

pkg/network/usm/utils/debugger_testutils.go

pkg/network/usm/utils/debugger.go

gjulianm

LGTM for ebpf-platform files other than a minor comment. Thanks for this!

pkg/gpu/probe.go

cit-pr-commenter · 2024-11-13T10:53:03Z

Go Package Import Differences

Baseline: bd393fa
Comparison: 845f4b2

binary	os	arch	change
system-probe	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/network/usm/consts
system-probe	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/network/usm/consts
system-probe	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/network/usm/consts

pkg/gpu/probe.go

pkg/network/usm/utils/debugger_test.go

guyarb · 2024-11-15T10:02:50Z

/merge

dd-devflow · 2024-11-15T10:02:57Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-15 10:02:57 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

2024-11-15 10:02:58 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 24m.

2024-11-15 10:12:18 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 73cce8b:

tests_ebpf_arm64

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

guyarb · 2024-11-18T05:45:18Z

/merge

dd-devflow · 2024-11-18T05:45:24Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-18 05:45:24 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

2024-11-18 05:45:25 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 24m.

github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Nov 12, 2024

guyarb added changelog/no-changelog team/usm The USM team qa/done QA done before merge and regressions are covered by tests labels Nov 12, 2024

guyarb added 2 commits November 12, 2024 19:23

usm: debugger: Add module name identifier

6a10902

The module name will allow us to distinguish between different modules using attachers, and will allow us to provide only relevant information for the usm debugging endpoints

usm: debugger: tests: Fixed tests to provide moduleName

7f67340

guyarb force-pushed the guy.arbitman/add-module-name-to-debugger branch from 93570a4 to 7f67340 Compare November 12, 2024 17:24

guyarb marked this pull request as ready for review November 12, 2024 17:24

guyarb requested review from a team as code owners November 12, 2024 17:24

guyarb requested a review from Jakobovski November 12, 2024 17:24

guyarb changed the title ~~Guy.arbitman/add module name to debugger~~ [usm] add module name to debugger Nov 12, 2024

hmahmood approved these changes Nov 12, 2024

View reviewed changes

usm: debugger: Added windows stubs

1dbad71

amitslavin requested changes Nov 13, 2024

View reviewed changes

pkg/network/usm/utils/debugger.go Outdated Show resolved Hide resolved

pkg/network/usm/utils/debugger.go Show resolved Hide resolved

pkg/network/usm/utils/debugger_testutils.go Show resolved Hide resolved

pkg/network/usm/utils/debugger.go Show resolved Hide resolved

gjulianm approved these changes Nov 13, 2024

View reviewed changes

pkg/gpu/probe.go Outdated Show resolved Hide resolved

guyarb added 5 commits November 13, 2024 12:25

gpu: Added a constant for gpu module name

9471355

tests: Use a constant for test module name

a186699

tests: Use a constant for test module name

12e1ae5

gpu: Added a constant for gpu module name in tests

c1a0f2e

usm: Use a constant for the module name

264a038

guyarb added 2 commits November 13, 2024 13:14

usm: Use a constant for the module name

bd3886a

usm: Updated documentation

5352dbc

val06 reviewed Nov 13, 2024

View reviewed changes

pkg/gpu/probe.go Show resolved Hide resolved

Jakobovski approved these changes Nov 13, 2024

View reviewed changes

usm: tests: Added coverage for runAttacherCallback

c2f328e

amitslavin approved these changes Nov 14, 2024

View reviewed changes

pkg/network/usm/utils/debugger_test.go Outdated Show resolved Hide resolved

Remove comment

5ad3b4f

guyarb added 3 commits November 18, 2024 00:08

Merge branch 'main' into guy.arbitman/add-module-name-to-debugger

352dd75

gpu: fix test after merge

80d6edc

gpu: fix test after merge

845f4b2

dd-mergequeue bot merged commit 41dc415 into main Nov 18, 2024
304 checks passed

dd-mergequeue bot deleted the guy.arbitman/add-module-name-to-debugger branch November 18, 2024 06:21

github-actions bot added this to the 7.61.0 milestone Nov 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[usm] add module name to debugger #31003

[usm] add module name to debugger #31003

guyarb commented Nov 12, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 12, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 12, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

gjulianm left a comment

cit-pr-commenter bot commented Nov 13, 2024 •

edited

Loading

guyarb commented Nov 15, 2024

dd-devflow bot commented Nov 15, 2024 •

edited

Loading

guyarb commented Nov 18, 2024

dd-devflow bot commented Nov 18, 2024 •

edited

Loading

[usm] add module name to debugger #31003

[usm] add module name to debugger #31003

Conversation

guyarb commented Nov 12, 2024 • edited Loading

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Nov 12, 2024 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Nov 12, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

gjulianm left a comment

Choose a reason for hiding this comment

cit-pr-commenter bot commented Nov 13, 2024 • edited Loading

Go Package Import Differences

guyarb commented Nov 15, 2024

dd-devflow bot commented Nov 15, 2024 • edited Loading

Devflow running: /merge

What to do next?

guyarb commented Nov 18, 2024

dd-devflow bot commented Nov 18, 2024 • edited Loading

Devflow running: /merge

guyarb commented Nov 12, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 12, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 12, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 13, 2024 •

edited

Loading

dd-devflow bot commented Nov 15, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Nov 18, 2024 •

edited

Loading

Devflow running: `/merge`