Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qa_agent): Use servercore windows images #31045

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Nov 13, 2024

What does this PR do?

Use the servercore images for windows in the qa_agent job

Motivation

Fix the error in the current job. I switched to the servercore images for Agent 6 according to this comment, but I'm not 100% sure of the consequences. The qa_agent complains because the v48815828-6d1ef8d8-6-win1809-amd64 does not exist, I'm not sure I can replace it with servercore image

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested review from a team as code owners November 13, 2024 16:50
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 13, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48997455 --os-family=ubuntu

@chouetz chouetz force-pushed the nschweitzer/qa_agent branch from 20476c8 to 81e1feb Compare November 14, 2024 10:11
@chouetz
Copy link
Member Author

chouetz commented Nov 14, 2024

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Nov 14, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2024-11-14 10:30:50 UTC ℹ️ Gitlab pipeline started

Started pipeline #48997455

@chouetz chouetz merged commit 1c94ae5 into 6.53.x Nov 15, 2024
190 of 221 checks passed
@chouetz chouetz deleted the nschweitzer/qa_agent branch November 15, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants