-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use fork of go-ora/v2, with compressed json based string conversion tables #31063
base: main
Are you sure you want to change the base?
Conversation
Go Package Import DifferencesBaseline: ea648f3
|
d1334fa
to
75b3211
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: ea648f3 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_idle_all_features | memory utilization | +1.63 | [+1.51, +1.76] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.79 | [+0.07, +1.51] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.75 | [+0.71, +0.79] | 1 | Logs bounds checks dashboard |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.56 | [+0.51, +0.61] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.42 | [-0.24, +1.08] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.32 | [-0.45, +1.10] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.27 | [-0.48, +1.03] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.25 | [-0.38, +0.89] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.16 | [-0.71, +1.03] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.06 | [-0.79, +0.91] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.66, +0.68] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.84, +0.83] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.11, +0.10] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.09 | [-0.54, +0.37] | 1 | Logs |
➖ | file_tree | memory utilization | -0.22 | [-0.34, -0.10] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -1.95 | [-4.82, +0.92] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_0ms_latency | lost_bytes | 8/10 | |
❌ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 8/10 | |
❌ | file_to_blackhole_500ms_latency | lost_bytes | 9/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
75b3211
to
3c7b455
Compare
982daf1
to
ea1b282
Compare
Package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
What does this PR do?
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes