Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fork of go-ora/v2, with compressed json based string conversion tables #31063

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 14, 2024
Copy link

cit-pr-commenter bot commented Nov 14, 2024

Go Package Import Differences

Baseline: ea648f3
Comparison: ea1b282

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/sijms/go-ora/v2/lazy_init
agentlinuxarm64
+1, -0
+github.com/sijms/go-ora/v2/lazy_init
agentwindowsamd64
+1, -0
+github.com/sijms/go-ora/v2/lazy_init
agentdarwinamd64
+1, -0
+github.com/sijms/go-ora/v2/lazy_init
agentdarwinarm64
+1, -0
+github.com/sijms/go-ora/v2/lazy_init

@paulcacheux paulcacheux force-pushed the paulcacheux/go-ora-json branch from d1334fa to 75b3211 Compare November 14, 2024 09:50
Copy link

cit-pr-commenter bot commented Nov 14, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d40156da-a079-43fd-8b1a-407822c60eb1

Baseline: ea648f3
Comparison: ea1b282
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +1.63 [+1.51, +1.76] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.79 [+0.07, +1.51] 1 Logs
quality_gate_idle memory utilization +0.75 [+0.71, +0.79] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.56 [+0.51, +0.61] 1 Logs
otel_to_otel_logs ingress throughput +0.42 [-0.24, +1.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.32 [-0.45, +1.10] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.27 [-0.48, +1.03] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.25 [-0.38, +0.89] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.16 [-0.71, +1.03] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.06 [-0.79, +0.91] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.66, +0.68] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.84, +0.83] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.10] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.09 [-0.54, +0.37] 1 Logs
file_tree memory utilization -0.22 [-0.34, -0.10] 1 Logs
quality_gate_logs % cpu utilization -1.95 [-4.82, +0.92] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 8/10
file_to_blackhole_0ms_latency_http2 lost_bytes 8/10
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux paulcacheux force-pushed the paulcacheux/go-ora-json branch from 75b3211 to 3c7b455 Compare November 16, 2024 11:30
@paulcacheux paulcacheux force-pushed the paulcacheux/go-ora-json branch from 982daf1 to ea1b282 Compare December 10, 2024 18:20
@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor ea648f38c679860629c00e9ccc465fcb4593279c

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb -9.92MB 1262.78MB 1272.69MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.20MB 113.20MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 527.85MB 527.85MB 70.00MB
datadog-agent-x86_64-rpm -9.92MB 1272.01MB 1281.93MB 140.00MB
datadog-agent-x86_64-suse -9.92MB 1272.01MB 1281.93MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.26MB 113.26MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.26MB 113.26MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb -9.93MB 995.52MB 1005.44MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.67MB 108.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm -9.93MB 1004.73MB 1014.66MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.74MB 108.74MB 10.00MB

Decision

✅ Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant