Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use remote tagger for non core agents #31076

Closed
wants to merge 1 commit into from

Conversation

GustavoCaso
Copy link
Member

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added component/system-probe team/container-platform The Container Platform Team long review PR is complex, plan time to review it labels Nov 14, 2024
Copy link

cit-pr-commenter bot commented Nov 14, 2024

Go Package Import Differences

This comment was omitted because it was over 65,536 characters. Please check the Gitlab Job logs to see its output.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 14, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49005153 --os-family=ubuntu

Note: This applies to commit 395634d

Copy link

cit-pr-commenter bot commented Nov 14, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0ded0b72-c8e5-44f4-96cd-718f50e30672

Baseline: 76557ae
Comparison: 395634d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +0.53 [-3.21, +4.27] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.30 [-0.19, +0.79] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.25 [-0.23, +0.73] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.09 [+0.04, +0.15] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.43, +0.47] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.09, +0.08] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.19, +0.18] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.35, +0.32] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.27, +0.22] 1 Logs
otel_to_otel_logs ingress throughput -0.13 [-0.80, +0.54] 1 Logs
file_tree memory utilization -1.18 [-1.31, -1.05] 1 Logs
quality_gate_idle_all_features memory utilization -1.26 [-1.37, -1.16] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization -1.44 [-4.83, +1.95] 1 Logs
quality_gate_idle memory utilization -2.90 [-2.95, -2.86] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -3.15 [-3.85, -2.44] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@GustavoCaso GustavoCaso force-pushed the use-remote-atger-for-non-core-agents branch from 9df041e to 395634d Compare November 14, 2024 12:30
@github-actions github-actions bot added medium review PR review might take time and removed component/system-probe long review PR is complex, plan time to review it labels Nov 14, 2024
@@ -113,11 +113,7 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
AgentType: catalog,
}
}),
dualTaggerfx.Module(tagger.DualParams{
UseRemote: func(c config.Component) bool {
return c.GetBool("security_agent.remote_tagger")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the config as well, since it's no longer used ?

@GustavoCaso GustavoCaso deleted the use-remote-atger-for-non-core-agents branch November 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants