Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installer): Support scope expressions #31109

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

BaptisteFoy
Copy link
Contributor

@BaptisteFoy BaptisteFoy commented Nov 15, 2024

What does this PR do?

Supports scope expressions for Fleet Automation policies in the installer

Motivation

Describe how to test/QA your changes

Tested manually with a custom config containing a scope & a custom installer build

Possible Drawbacks / Trade-offs

Additional Notes

@BaptisteFoy BaptisteFoy added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Nov 15, 2024
@github-actions github-actions bot added the medium review PR review might take time label Nov 15, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 15, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49236271 --os-family=ubuntu

Note: This applies to commit dcada97

Copy link

cit-pr-commenter bot commented Nov 15, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8be563f8-6d24-4ad9-885e-7daa794f2e23

Baseline: 41dc415
Comparison: dcada97
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization -5.33 [-8.99, -1.66] 1 Logs
pycheck_lots_of_tags % cpu utilization -5.40 [-8.70, -2.09] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.94 [+1.75, +2.14] 1 Logs
otel_to_otel_logs ingress throughput +1.11 [+0.43, +1.80] 1 Logs
quality_gate_idle memory utilization +0.47 [+0.42, +0.52] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.39 [-0.07, +0.85] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.64, +0.69] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.61, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.10] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.87, +0.84] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.83, +0.72] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.84, +0.71] 1 Logs
file_tree memory utilization -0.09 [-0.22, +0.05] 1 Logs
quality_gate_idle_all_features memory utilization -0.27 [-0.38, -0.16] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.15 [-1.87, -0.43] 1 Logs
basic_py_check % cpu utilization -5.33 [-8.99, -1.66] 1 Logs
pycheck_lots_of_tags % cpu utilization -5.40 [-8.70, -2.09] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_1000ms_latency lost_bytes 0/10
file_to_blackhole_100ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/scope-expressions branch from 07e0999 to 8d434dd Compare November 15, 2024 11:47
@BaptisteFoy BaptisteFoy marked this pull request as ready for review November 15, 2024 11:47
@BaptisteFoy BaptisteFoy requested review from a team as code owners November 15, 2024 11:47
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/scope-expressions branch 2 times, most recently from 8d2b49f to a8e4564 Compare November 15, 2024 16:10
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/scope-expressions branch from a8e4564 to 1c84ec7 Compare November 17, 2024 17:48
@BaptisteFoy BaptisteFoy added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests and removed changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Nov 18, 2024
@BaptisteFoy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-18 13:13:13 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit 5b89921 into main Nov 18, 2024
224 of 225 checks passed
@dd-mergequeue dd-mergequeue bot deleted the baptiste.foy/FA/scope-expressions branch November 18, 2024 14:14
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants