ci(non-gitlab): [agent6] Misc updates #31130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
added
changelog/no-changelog
qa/no-code-change
chouetz
changed the title
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=49138380 --os-family=ubuntu |
Co-authored-by: sblumenthal <steven.blumenthal@datadoghq.com> Co-authored-by: spencergilbert <spencer.gilbert@datadoghq.com>
KevinFairise2
approved these changes
Nov 18, 2024
tasks/docker_tasks.py
Outdated
| @@ -54,8 +54,11 @@ def dockerize_test(ctx, binary, skip_cleanup=False): | |||
|
|
|||
| with open(f"{temp_folder}/Dockerfile", 'w') as stream: | |||
| stream.write( | |||
| """FROM docker/compose:debian-1.29.2 | |||
| """FROM ubuntu:20.04 | |||
| COPY --from=docker/compose-bin:v2.26.1 /docker-compose /usr/bin/compose | |||
There was a problem hiding this comment.
I wonder if we should use this version: https://github.com/DataDog/datadog-agent/pull/30699/files
Or if we think that we should not get rate limited on that branch
CelianR
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
iotordogstatsdfor agent6 #31019Motivation
https://datadoghq.atlassian.net/browse/ACIX-455
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes