-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump mockery to 2.49.2 #31135
bump mockery to 2.49.2 #31135
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50334775 --os-family=ubuntu Note: This applies to commit 1df536c |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: a79d704 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | otel_to_otel_logs | ingress throughput | +1.37 | [+0.71, +2.03] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.78 | [+0.05, +1.52] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +0.62 | [-2.37, +3.62] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +0.49 | [+0.38, +0.61] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.41 | [-0.06, +0.87] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.06 | [+0.00, +0.12] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.71, +0.76] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.01 | [-0.77, +0.76] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.11, +0.09] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.90, +0.87] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.04 | [-0.66, +0.59] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -0.04 | [-3.41, +3.34] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.23 | [-0.28, -0.19] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.35 | [-1.13, +0.44] | 1 | Logs |
➖ | file_tree | memory utilization | -0.52 | [-0.65, -0.38] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -1.27 | [-5.05, +2.52] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
5be92f8
to
27ef385
Compare
c45347b
to
e6464d3
Compare
e6464d3
to
e5845d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e5845d1
to
1df536c
Compare
/merge |
Devflow running:
|
What does this PR do?
Depends on: #31022 <- the go 1.23 upgrade PR
This PR bumps mockery to latest version (2.49.2), and re-generates the mock files.
No code change, only comments.
Motivation
This will allow us to re-enabled our "are mocks up to date?" check that was disabled in #31137, in preparation of go1.23 upgrade.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes