usm: http2: Unify telemetry maps #31154
Conversation
Each eBPF map has a minimum size in bytes. Having plaintext and tls map versions for telemetry introduced a waste in memory cost, and redundant code duplication. Instead of having 2 maps with a single entry each, we can have a single map with 2 entries.
guyarb
added
changelog/no-changelog
team/usm
github-actions
bot
added
component/system-probe
medium review
|
[Fast Unit Tests Report] On pipeline 49214366 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=49214366 --os-family=ubuntuNote: This applies to commit 76c3590 |
eBPF complexity changesSummary result: ✅ - stable
usm detailsusm [programs with changes]
usm [programs without changes]
This report was generated based on the complexity data for the current branch guy.arbitman/http2-unify-telemetry-maps (pipeline 49214366, commit 76c3590) and the base branch main (commit dd3da58). Objects without changes are not reported. Contact #ebpf-platform if you have any questions/feedback. Table complexity legend: 🔵 - new; ⚪ - unchanged; 🟢 - reduced; 🔴 - increased |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: dd3da58 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.77 | [+2.02, +3.51] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +1.15 | [+1.05, +1.25] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.56 | [+0.42, +0.69] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.31 | [+0.27, +0.36] | 1 | Logs bounds checks dashboard |
| ➖ | basic_py_check | % cpu utilization | +0.27 | [-3.58, +4.11] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.21 | [-0.49, +0.91] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.19 | [-0.27, +0.65] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.03 | [-0.60, +0.65] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.10, +0.10] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.76, +0.73] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.79, +0.76] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.06 | [-0.90, +0.77] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.32 | [-0.40, -0.25] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.44 | [-1.21, +0.34] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -0.82 | [-4.20, +2.56] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_1000ms_latency | lost_bytes | 0/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
Devflow running:
|
dd-mergequeue
bot
deleted the
guy.arbitman/http2-unify-telemetry-maps
branch
What does this PR do?
Unifies http2 telemetry maps (plaintext + tls) into a single map
Motivation
Each eBPF map has a minimum size in bytes. Having plaintext and tls map versions for telemetry introduced a waste in memory cost, and redundant code duplication. Instead of having 2 maps with a single entry each, we can have a single map with 2 entries.
Describe how to test/QA your changes
There's an automated test
TestHTTP2KernelTelemetry()Possible Drawbacks / Trade-offs
Additional Notes