[Serverless] Add _dd.tags.function to tracer payload tags. #31358

purple4reina · 2024-11-21T20:27:41Z

DO NOT MERGE!

This PR is in place as phase 1 of the serverless usage metrics tagging work. A test function will be deployed with this code and it will then be used as we work on changes to intake. Ultimately, these changes will eventually be re-implemented in our rust based agent. It is therefore okay if these changes to the go based agent are never released.

What does this PR do?

Move trace "Extra Tags" from the span to the TracePayload.Tags field.

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2024-11-21T21:20:02Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f646d4cc-8c0f-4d12-a9e4-74c7eed121f4

Baseline: 90249a8
Comparison: 9d38245
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otel_to_otel_logs	ingress throughput	+0.62	[-0.07, +1.31]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.46	[-2.51, +3.42]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.06	[-0.57, +0.68]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.11, +0.08]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.03	[-0.81, +0.76]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.03	[-0.88, +0.83]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.03	[-0.82, +0.76]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.07	[-0.95, +0.80]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.23	[-0.28, -0.18]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.28	[-1.05, +0.48]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.44	[-0.90, +0.03]	1	Logs
➖	file_tree	memory utilization	-0.63	[-0.75, -0.50]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.70	[-1.48, +0.08]	1	Logs
➖	quality_gate_idle	memory utilization	-0.91	[-0.96, -0.86]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.93	[-1.05, -0.81]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.96	[-1.68, -0.24]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency_http1	lost_bytes	8/10
❌	file_to_blackhole_0ms_latency_http2	lost_bytes	8/10
❌	file_to_blackhole_100ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2024-11-22T21:32:29Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50976342 --os-family=ubuntu

Note: This applies to commit bbfbc49

agent-platform-auto-pr · 2024-12-12T16:55:42Z

Package size comparison

Comparison with ancestor 90249a8cc795481097640d46328e784f4b9d1396

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1265.73MB	1265.73MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.24MB	113.24MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.41MB	78.41MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	526.58MB	526.58MB	70.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1274.97MB	1274.97MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1274.97MB	1274.97MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.31MB	113.31MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.31MB	113.31MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.49MB	78.49MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.49MB	78.49MB	10.00MB
datadog-agent-arm64-deb	0.00MB	✅	1000.85MB	1000.85MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.72MB	108.72MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.65MB	55.65MB	10.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	1010.07MB	1010.07MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.79MB	108.79MB	10.00MB

Decision

✅ Passed

github-actions · 2024-12-13T19:30:00Z

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between c50e6cf and 6753331.

tl;dr

Use these benchmarks as an insight tool during development.

Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.
The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                           86.89µ ± 12%   86.90µ ± 1%       ~ (p=0.971 n=10)
api-gateway-kong-appsec.json                      67.67µ ±  2%   67.42µ ± 6%       ~ (p=1.000 n=10)
api-gateway-kong.json                             64.75µ ±  1%   64.16µ ± 1%       ~ (p=0.105 n=10)
api-gateway-non-proxy-async.json                  103.5µ ±  4%   101.8µ ± 1%       ~ (p=0.579 n=10)
api-gateway-non-proxy.json                        100.1µ ±  2%   101.6µ ± 1%       ~ (p=0.052 n=10)
api-gateway-websocket-connect.json                64.48µ ±  4%   65.11µ ± 2%       ~ (p=0.143 n=10)
api-gateway-websocket-default.json                57.36µ ±  2%   58.95µ ± 1%  +2.76% (p=0.001 n=10)
api-gateway-websocket-disconnect.json             58.04µ ±  2%   58.62µ ± 1%       ~ (p=0.143 n=10)
api-gateway.json                                  107.1µ ±  5%   109.0µ ± 1%       ~ (p=0.481 n=10)
application-load-balancer.json                    56.91µ ±  1%   58.82µ ± 3%  +3.35% (p=0.001 n=10)
cloudfront.json                                   43.75µ ±  2%   44.42µ ± 2%  +1.54% (p=0.011 n=10)
cloudwatch-events.json                            35.96µ ±  1%   37.53µ ± 1%  +4.35% (p=0.000 n=10)
cloudwatch-logs.json                              59.29µ ±  2%   59.77µ ± 1%       ~ (p=0.105 n=10)
custom.json                                       30.26µ ±  1%   31.51µ ± 1%  +4.15% (p=0.000 n=10)
dynamodb.json                                     83.26µ ±  1%   84.98µ ± 2%  +2.07% (p=0.000 n=10)
empty.json                                        29.14µ ±  3%   29.91µ ± 1%  +2.64% (p=0.015 n=10)
eventbridge-custom.json                           46.87µ ±  1%   47.23µ ± 1%       ~ (p=0.063 n=10)
eventbridge-no-bus.json                           46.36µ ±  1%   45.94µ ± 1%       ~ (p=0.165 n=10)
eventbridge-no-timestamp.json                     46.08µ ±  2%   45.83µ ± 1%       ~ (p=0.089 n=10)
eventbridgesns.json                               61.54µ ±  1%   59.73µ ± 1%  -2.94% (p=0.000 n=10)
eventbridgesqs.json                               67.13µ ±  2%   66.11µ ± 1%  -1.52% (p=0.009 n=10)
http-api.json                                     66.36µ ±  1%   66.18µ ± 1%       ~ (p=0.631 n=10)
kinesis-batch.json                                66.23µ ±  1%   65.15µ ± 1%  -1.63% (p=0.000 n=10)
kinesis.json                                      52.96µ ±  1%   52.41µ ± 1%  -1.03% (p=0.007 n=10)
s3.json                                           56.77µ ±  1%   56.12µ ± 1%       ~ (p=0.075 n=10)
sns-batch.json                                    83.08µ ±  0%   83.85µ ± 1%  +0.92% (p=0.004 n=10)
sns.json                                          63.58µ ±  2%   63.55µ ± 2%       ~ (p=0.579 n=10)
snssqs.json                                       106.0µ ±  1%   105.5µ ± 2%       ~ (p=0.912 n=10)
snssqs_no_dd_context.json                         97.45µ ±  2%   96.44µ ± 1%  -1.03% (p=0.043 n=10)
sqs-aws-header.json                               54.34µ ±  1%   54.29µ ± 1%       ~ (p=0.631 n=10)
sqs-batch.json                                    86.91µ ±  2%   87.69µ ± 1%       ~ (p=0.579 n=10)
sqs.json                                          64.95µ ±  1%   64.96µ ± 1%       ~ (p=0.684 n=10)
sqs_no_dd_context.json                            59.72µ ±  2%   59.51µ ± 1%       ~ (p=0.971 n=10)
stepfunction.json                                 42.55µ ±  1%   42.15µ ± 1%       ~ (p=0.218 n=10)
geomean                                           61.89µ         62.13µ       +0.39%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.27Ki ± 0%   37.66Ki ± 0%  +1.04% (p=0.000 n=10)
api-gateway-kong-appsec.json                      26.91Ki ± 0%   27.23Ki ± 0%  +1.22% (p=0.000 n=10)
api-gateway-kong.json                             24.37Ki ± 0%   24.70Ki ± 0%  +1.36% (p=0.000 n=10)
api-gateway-non-proxy-async.json                  47.94Ki ± 0%   48.33Ki ± 0%  +0.81% (p=0.000 n=10)
api-gateway-non-proxy.json                        47.12Ki ± 0%   47.50Ki ± 0%  +0.82% (p=0.000 n=10)
api-gateway-websocket-connect.json                25.34Ki ± 0%   25.70Ki ± 0%  +1.42% (p=0.000 n=10)
api-gateway-websocket-default.json                21.23Ki ± 0%   21.59Ki ± 0%  +1.70% (p=0.000 n=10)
api-gateway-websocket-disconnect.json             20.99Ki ± 0%   21.35Ki ± 0%  +1.72% (p=0.000 n=10)
api-gateway.json                                  49.26Ki ± 0%   49.60Ki ± 0%  +0.69% (p=0.000 n=10)
application-load-balancer.json                    22.46Ki ± 0%   23.72Ki ± 0%  +5.63% (p=0.000 n=10)
cloudfront.json                                   17.44Ki ± 0%   17.78Ki ± 0%  +1.97% (p=0.000 n=10)
cloudwatch-events.json                            11.49Ki ± 0%   11.85Ki ± 0%  +3.12% (p=0.000 n=10)
cloudwatch-logs.json                              53.05Ki ± 0%   53.38Ki ± 0%  +0.62% (p=0.000 n=10)
custom.json                                       9.529Ki ± 0%   9.873Ki ± 0%  +3.61% (p=0.000 n=10)
dynamodb.json                                     40.30Ki ± 0%   40.66Ki ± 0%  +0.89% (p=0.000 n=10)
empty.json                                        9.066Ki ± 0%   9.411Ki ± 0%  +3.80% (p=0.000 n=10)
eventbridge-custom.json                           14.67Ki ± 0%   15.00Ki ± 0%  +2.24% (p=0.000 n=10)
eventbridge-no-bus.json                           13.63Ki ± 0%   13.96Ki ± 0%  +2.41% (p=0.000 n=10)
eventbridge-no-timestamp.json                     13.63Ki ± 0%   13.96Ki ± 0%  +2.41% (p=0.000 n=10)
eventbridgesns.json                               20.43Ki ± 0%   20.79Ki ± 0%  +1.76% (p=0.000 n=10)
eventbridgesqs.json                               24.56Ki ± 0%   24.92Ki ± 0%  +1.47% (p=0.000 n=10)
http-api.json                                     23.25Ki ± 0%   23.64Ki ± 0%  +1.69% (p=0.000 n=10)
kinesis-batch.json                                26.50Ki ± 0%   26.85Ki ± 0%  +1.35% (p=0.000 n=10)
kinesis.json                                      17.38Ki ± 0%   17.73Ki ± 0%  +2.06% (p=0.000 n=10)
s3.json                                           19.87Ki ± 0%   20.23Ki ± 0%  +1.81% (p=0.000 n=10)
sns-batch.json                                    39.08Ki ± 0%   39.40Ki ± 0%  +0.84% (p=0.000 n=10)
sns.json                                          24.49Ki ± 0%   24.82Ki ± 0%  +1.34% (p=0.000 n=10)
snssqs.json                                       52.68Ki ± 0%   53.07Ki ± 0%  +0.74% (p=0.000 n=10)
snssqs_no_dd_context.json                         46.44Ki ± 0%   46.82Ki ± 0%  +0.83% (p=0.000 n=10)
sqs-aws-header.json                               18.78Ki ± 0%   19.11Ki ± 0%  +1.75% (p=0.000 n=10)
sqs-batch.json                                    41.26Ki ± 0%   41.59Ki ± 0%  +0.79% (p=0.000 n=10)
sqs.json                                          25.39Ki ± 0%   25.72Ki ± 0%  +1.29% (p=0.000 n=10)
sqs_no_dd_context.json                            21.01Ki ± 0%   21.37Ki ± 0%  +1.71% (p=0.000 n=10)
stepfunction.json                                 13.51Ki ± 0%   13.87Ki ± 0%  +2.66% (p=0.000 n=10)
geomean                                           24.10Ki        24.52Ki       +1.75%

                                      │ baseline/benchmark.log │       current/benchmark.log       │
                                      │       allocs/op        │ allocs/op   vs base               │
api-gateway-appsec.json                             630.0 ± 0%   632.0 ± 0%  +0.32% (p=0.000 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   490.0 ± 0%  +0.41% (p=0.000 n=10)
api-gateway-kong.json                               466.0 ± 0%   468.0 ± 0%  +0.43% (p=0.000 n=10)
api-gateway-non-proxy-async.json                    723.0 ± 0%   725.0 ± 0%  +0.28% (p=0.000 n=10)
api-gateway-non-proxy.json                          713.0 ± 0%   715.0 ± 0%  +0.28% (p=0.000 n=10)
api-gateway-websocket-connect.json                  451.0 ± 0%   453.0 ± 0%  +0.44% (p=0.000 n=10)
api-gateway-websocket-default.json                  376.0 ± 0%   378.0 ± 0%  +0.53% (p=0.000 n=10)
api-gateway-websocket-disconnect.json               366.0 ± 0%   368.0 ± 0%  +0.55% (p=0.000 n=10)
api-gateway.json                                    785.0 ± 0%   787.0 ± 0%  +0.25% (p=0.000 n=10)
application-load-balancer.json                      350.0 ± 0%   353.0 ± 0%  +0.86% (p=0.000 n=10)
cloudfront.json                                     281.0 ± 0%   283.0 ± 0%  +0.71% (p=0.000 n=10)
cloudwatch-events.json                              218.0 ± 0%   220.0 ± 0%  +0.92% (p=0.000 n=10)
cloudwatch-logs.json                                211.0 ± 0%   213.0 ± 0%  +0.95% (p=0.000 n=10)
custom.json                                         166.0 ± 0%   168.0 ± 0%  +1.20% (p=0.000 n=10)
dynamodb.json                                       582.0 ± 0%   584.0 ± 0%  +0.34% (p=0.000 n=10)
empty.json                                          157.0 ± 0%   159.0 ± 0%  +1.27% (p=0.000 n=10)
eventbridge-custom.json                             261.0 ± 0%   263.0 ± 0%  +0.77% (p=0.000 n=10)
eventbridge-no-bus.json                             252.0 ± 0%   254.0 ± 0%  +0.79% (p=0.000 n=10)
eventbridge-no-timestamp.json                       252.0 ± 0%   254.0 ± 0%  +0.79% (p=0.000 n=10)
eventbridgesns.json                                 318.0 ± 0%   320.0 ± 0%  +0.63% (p=0.000 n=10)
eventbridgesqs.json                                 358.0 ± 0%   360.0 ± 0%  +0.56% (p=0.000 n=10)
http-api.json                                       424.0 ± 0%   426.0 ± 0%  +0.47% (p=0.000 n=10)
kinesis-batch.json                                  383.0 ± 0%   385.0 ± 0%  +0.52% (p=0.000 n=10)
kinesis.json                                        279.0 ± 0%   281.0 ± 0%  +0.72% (p=0.000 n=10)
s3.json                                             351.0 ± 0%   353.0 ± 0%  +0.57% (p=0.000 n=10)
sns-batch.json                                      465.0 ± 0%   467.0 ± 0%  +0.43% (p=0.000 n=10)
sns.json                                            336.0 ± 0%   338.0 ± 0%  +0.60% (p=0.000 n=10)
snssqs.json                                         460.0 ± 0%   462.0 ± 0%  +0.43% (p=0.000 n=10)
snssqs_no_dd_context.json                           420.0 ± 0%   422.0 ± 0%  +0.48% (p=0.000 n=10)
sqs-aws-header.json                                 276.0 ± 0%   278.0 ± 0%  +0.72% (p=0.000 n=10)
sqs-batch.json                                      500.0 ± 0%   502.0 ± 0%  +0.40% (p=0.000 n=10)
sqs.json                                            351.0 ± 0%   353.0 ± 0%  +0.57% (p=0.000 n=10)
sqs_no_dd_context.json                              337.0 ± 0%   339.0 ± 0%  +0.59% (p=0.000 n=10)
stepfunction.json                                   226.0 ± 0%   228.0 ± 0%  +0.88% (p=0.000 n=10)
geomean                                             360.1        362.2       +0.61%

purple4reina added changelog/no-changelog team/serverless qa/done QA done before merge and regressions are covered by tests labels Nov 21, 2024

purple4reina added this to the Triage milestone Nov 21, 2024

github-actions bot added the medium review PR review might take time label Nov 21, 2024

github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Nov 22, 2024

purple4reina force-pushed the rey.abolofia/func-tags branch from 738381e to 3b8a172 Compare November 22, 2024 20:40

purple4reina changed the title ~~[Serverless] Replace individual trace tags with single _dd.tags.function.~~ [Serverless] Add _dd.tags.function to aws.lambda span meta. Nov 22, 2024

Add function tags to TracerPayload.

bbfbc49

purple4reina force-pushed the rey.abolofia/func-tags branch from bd37d3b to bbfbc49 Compare December 12, 2024 16:28

purple4reina changed the title ~~[Serverless] Add _dd.tags.function to aws.lambda span meta.~~ [Serverless] Add _dd.tags.function to tracer payload tags. Dec 12, 2024

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 13, 2024

Method for creating flattened function tags.

60df1c5

purple4reina force-pushed the rey.abolofia/func-tags branch from 29ed8b7 to 60df1c5 Compare December 13, 2024 19:13

github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Dec 13, 2024

Remove function tags from their normal location.

9d38245

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Serverless] Add _dd.tags.function to tracer payload tags. #31358

[Serverless] Add _dd.tags.function to tracer payload tags. #31358

purple4reina commented Nov 21, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 21, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

agent-platform-auto-pr bot commented Nov 22, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 12, 2024

github-actions bot commented Dec 13, 2024

[Serverless] Add _dd.tags.function to tracer payload tags. #31358

Are you sure you want to change the base?

[Serverless] Add _dd.tags.function to tracer payload tags. #31358

Conversation

purple4reina commented Nov 21, 2024 • edited Loading

DO NOT MERGE!

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter bot commented Nov 21, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Nov 22, 2024 • edited Loading

Test changes on VM

agent-platform-auto-pr bot commented Dec 12, 2024

Package size comparison

Decision

github-actions bot commented Dec 13, 2024

Serverless Benchmark Results

purple4reina commented Nov 21, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 21, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 22, 2024 •

edited

Loading