Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testify to 1.10.0 #31520

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Update testify to 1.10.0 #31520

merged 3 commits into from
Nov 29, 2024

Conversation

pgimalac
Copy link
Member

What does this PR do?

Update testify to the latest (1.10.0)

Motivation

Benefit from stretchr/testify#1481 to be able to use require in Eventually

Describe how to test/QA your changes

Covered by CI (this is a test dependency)

Possible Drawbacks / Trade-offs

Additional Notes

@pgimalac pgimalac added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-devx-loops labels Nov 27, 2024
@pgimalac pgimalac requested review from a team as code owners November 27, 2024 13:22
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Nov 27, 2024
Copy link

cit-pr-commenter bot commented Nov 27, 2024

Go Package Import Differences

Baseline: 6686f4d
Comparison: d44ed3a

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
agentlinuxarm64
+1, -0
+github.com/stretchr/testify/assert/yaml
agentwindowsamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
agentdarwinamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
agentdarwinarm64
+1, -0
+github.com/stretchr/testify/assert/yaml
iot-agentlinuxamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
iot-agentlinuxarm64
+1, -0
+github.com/stretchr/testify/assert/yaml
heroku-agentlinuxamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
serverlesslinuxamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
serverlesslinuxarm64
+1, -0
+github.com/stretchr/testify/assert/yaml
system-probelinuxamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
system-probelinuxarm64
+1, -0
+github.com/stretchr/testify/assert/yaml
trace-agentlinuxamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
trace-agentlinuxarm64
+1, -0
+github.com/stretchr/testify/assert/yaml
trace-agentwindowsamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
trace-agentdarwinamd64
+1, -0
+github.com/stretchr/testify/assert/yaml
trace-agentdarwinarm64
+1, -0
+github.com/stretchr/testify/assert/yaml
heroku-trace-agentlinuxamd64
+1, -0
+github.com/stretchr/testify/assert/yaml

Copy link

cit-pr-commenter bot commented Nov 27, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0b15ba64-bca2-4a39-8fd6-7c21e50389d2

Baseline: 6686f4d
Comparison: d44ed3a
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +6.88 [+3.26, +10.51] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +6.88 [+3.26, +10.51] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.42 [-0.31, +1.15] 1 Logs
otel_to_otel_logs ingress throughput +0.40 [-0.24, +1.05] 1 Logs
quality_gate_idle_all_features memory utilization +0.34 [+0.24, +0.43] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.08 [-0.67, +0.83] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.77, +0.87] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.74, +0.80] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.09] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.22 [-0.68, +0.25] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.33 [-1.09, +0.44] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.33 [-0.96, +0.30] 1 Logs
file_tree memory utilization -0.38 [-0.52, -0.24] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.49 [-0.54, -0.43] 1 Logs
quality_gate_idle memory utilization -0.50 [-0.54, -0.45] 1 Logs bounds checks dashboard
basic_py_check % cpu utilization -1.20 [-4.98, +2.58] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50064993 --os-family=ubuntu

Note: This applies to commit d44ed3a

Copy link
Contributor

@misteriaud misteriaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice to be able to use require in EventuallyWithT 🎉

@louis-cqrl louis-cqrl removed the request for review from dustmop November 29, 2024 08:08
@pgimalac
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 29, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-29 14:22:14 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit ad40689 into main Nov 29, 2024
376 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/update-testify branch November 29, 2024 14:57
@github-actions github-actions bot added this to the 7.62.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.