Revert "[ASCII-2562] Migrate forward eventplatform component to the latest file structure" #31563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atest fi…" This reverts commit 974c354.
github-actions
bot
added
team/agent-metrics-logs
long review
GustavoCaso
added
changelog/no-changelog
qa/done
Go Package Import DifferencesBaseline: 3ac8f8c
|
pgimalac
approved these changes
Nov 28, 2024
jose-manuel-almaza
approved these changes
Nov 28, 2024
remeh
approved these changes
Nov 28, 2024
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats |
TCheruy
approved these changes
Nov 28, 2024
guyarb
approved these changes
Nov 28, 2024
vboulineau
approved these changes
Nov 28, 2024
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50102940 --os-family=ubuntuNote: This applies to commit 4f1ec16 |
AlexandreYang
approved these changes
Nov 28, 2024
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 3ac8f8c Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | pycheck_lots_of_tags | % cpu utilization | +1.83 | [-1.65, +5.31] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.26 | [-1.71, +4.23] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.70 | [+0.66, +0.75] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.33 | [-0.39, +1.06] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.28 | [+0.13, +0.44] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.14 | [-0.31, +0.60] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.08 | [-0.56, +0.71] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.08 | [-0.69, +0.85] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.82, +0.83] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.72, +0.73] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.10, +0.10] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.79, +0.75] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.49 | [-0.59, -0.39] | 1 | Logs bounds checks dashboard |
| ➖ | otel_to_otel_logs | ingress throughput | -0.70 | [-1.40, -0.01] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.72 | [-4.64, +3.20] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.33 | [-1.40, -1.27] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
davidor
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #31471
In the previous PR, the noop eventforwarder is not fully a noop and was found on one of the test for integrations core https://github.com/DataDog/integrations-core/actions/runs/12062846875/job/33645986581
Since there are a few subtle issues that we need to fix before having different implementations for eventplatform, I decided to revert the changes and unblock the integrations core pipeline