Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF] Backport KMT platform files to 6.53.x #31699

Open
wants to merge 12 commits into
base: 6.53.x
Choose a base branch
from

Conversation

gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Dec 3, 2024

What does this PR do?

This PR fixes the KMT code in the 6.53.x to be able to run KMT tests for Agent 6. More specifically, it changes the following:

For review, it's recommended to go commit-by-commit.

Motivation

KMT tests on agent 6 failed to run due to images being deleted after the changes in ami-builder and the KMT testing code. This PR allows KMT tests to reliably run in this branch.

Additional Notes

Reviewing commit-by-commit is easier, as each commit tackles a single problem that appeared.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

* Allow downloading images for all architectures

* Add update-platform-info task

* Improve output of kmt.ls

* Adapt to new platforms.json structure

* Use guestfs python package

* Ignore rescue images when detecting kernel

* Ignore empty version names

* Fix kernel detection

* Use dynamic distribution mappings

* Update platform info

* Remove empty alternative names

* Better help

* Fix archs for custom kernels

* Fix import order

* Fix format

* Use manifest files

* Improve sorting in kmt.ls

* Update platforms.json

* Warn when some images have not been updated

* Update platforms.json

* Update to latest images

* Raise an error when image is missing

* Fix platforms.json file

* Add kmt.validate-platform-info task

* review comments

* Improve kmt.ls

* Show an error when kernels are missing

* Fix image names in CI

* Switch Amazon 2023 version

* Use master version for AL2023

* test with updated names

* Update Amazon 2023 name

* Add --exclude-matching argument to update-platform-info task

* Update platforms.json
@gjulianm gjulianm self-assigned this Dec 3, 2024
@gjulianm gjulianm added changelog/no-changelog team/ebpf-platform qa/done QA done before merge and regressions are covered by tests labels Dec 3, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 3, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50853384 --os-family=ubuntu

@gjulianm gjulianm marked this pull request as ready for review December 4, 2024 08:41
@gjulianm gjulianm requested review from a team as code owners December 4, 2024 08:41
@gjulianm gjulianm marked this pull request as draft December 4, 2024 08:45
@gjulianm gjulianm force-pushed the guillermo.julian/backport-kmt branch 3 times, most recently from fbddd59 to 31a8122 Compare December 4, 2024 12:17
gjulianm and others added 9 commits December 11, 2024 14:01
Co-authored-by: agent-platform-auto-pr[bot] <153269286+agent-platform-auto-pr[bot]@users.noreply.github.com>
* add ninja status for debug

* try just tar, no gzip

* fix extension

* remove outdated comment
* add caching of minimized BTFs

* add --region

* fix brackets

* use abs path for download

* don't need brackets for command
@gjulianm gjulianm force-pushed the guillermo.julian/backport-kmt branch from 4d2faf2 to 91e530e Compare December 11, 2024 13:03
@gjulianm
Copy link
Contributor Author

/trigger-ci

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2024

Devflow running: /trigger-ci

View all feedbacks in Devflow UI.


2024-12-11 16:12:12 UTC ℹ️ Gitlab pipeline started

Started pipeline #50853384

@gjulianm gjulianm marked this pull request as ready for review December 12, 2024 10:34
@gjulianm gjulianm requested a review from a team as a code owner December 12, 2024 10:34
@gjulianm gjulianm requested review from a team as code owners December 12, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants