-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EBPF] Backport KMT platform files to 6.53.x #31699
Open
gjulianm
wants to merge
12
commits into
6.53.x
Choose a base branch
from
guillermo.julian/backport-kmt
base: 6.53.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+750
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow downloading images for all architectures * Add update-platform-info task * Improve output of kmt.ls * Adapt to new platforms.json structure * Use guestfs python package * Ignore rescue images when detecting kernel * Ignore empty version names * Fix kernel detection * Use dynamic distribution mappings * Update platform info * Remove empty alternative names * Better help * Fix archs for custom kernels * Fix import order * Fix format * Use manifest files * Improve sorting in kmt.ls * Update platforms.json * Warn when some images have not been updated * Update platforms.json * Update to latest images * Raise an error when image is missing * Fix platforms.json file * Add kmt.validate-platform-info task * review comments * Improve kmt.ls * Show an error when kernels are missing * Fix image names in CI * Switch Amazon 2023 version * Use master version for AL2023 * test with updated names * Update Amazon 2023 name * Add --exclude-matching argument to update-platform-info task * Update platforms.json
gjulianm
added
changelog/no-changelog
team/ebpf-platform
qa/done
QA done before merge and regressions are covered by tests
labels
Dec 3, 2024
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50853384 --os-family=ubuntu |
gjulianm
force-pushed
the
guillermo.julian/backport-kmt
branch
3 times, most recently
from
December 4, 2024 12:17
fbddd59
to
31a8122
Compare
Co-authored-by: agent-platform-auto-pr[bot] <153269286+agent-platform-auto-pr[bot]@users.noreply.github.com>
* add ninja status for debug * try just tar, no gzip * fix extension * remove outdated comment
* add caching of minimized BTFs * add --region * fix brackets * use abs path for download * don't need brackets for command
gjulianm
force-pushed
the
guillermo.julian/backport-kmt
branch
from
December 11, 2024 13:03
4d2faf2
to
91e530e
Compare
/trigger-ci |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
component/system-probe
qa/done
QA done before merge and regressions are covered by tests
team/ebpf-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the KMT code in the 6.53.x to be able to run KMT tests for Agent 6. More specifically, it changes the following:
platforms.json
file. This makes it easier to manage image versions, and also enables the corresponding code in ami-builder (https://github.com/DataDog/ami-builder/pull/208) to detect the images being used in support branches.DD_API_KEY
as an env variable in the microVMsbtfhub-archive
formats.main
branch forbtfhub-archive
as we need the latest BTF definitions for the updated KMT images.For review, it's recommended to go commit-by-commit.
Motivation
KMT tests on agent 6 failed to run due to images being deleted after the changes in ami-builder and the KMT testing code. This PR allows KMT tests to reliably run in this branch.
Additional Notes
Reviewing commit-by-commit is easier, as each commit tackles a single problem that appeared.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes