Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modules missing on this release #32132

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented Dec 13, 2024

What does this PR do?

Removes comp/core/tagger/tags which is not valid on this release.
Verified that the number of modules matched

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@CelianR CelianR added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra labels Dec 13, 2024
@CelianR CelianR self-assigned this Dec 13, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 13, 2024
@chouquette chouquette changed the title Removed all module Remove modules missing on this release Dec 13, 2024
@chouquette
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-13 12:21:06 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in 7.60.x is 40m.


2024-12-13 12:43:20 UTC ℹ️ MergeQueue: This merge request was merged

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51063084 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a271da6e-e996-4afe-b195-e39f2155a169

Baseline: 7d964f2
Comparison: f24f570
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +1.44 [-2.10, +4.98] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.62 [+0.57, +0.67] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.56 [+0.07, +1.05] 1 Logs
quality_gate_idle_all_features memory utilization +0.46 [+0.36, +0.57] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.24 [+0.19, +0.28] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.15, +0.21] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.22, +0.23] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.33, +0.34] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.10] 1 Logs
idle memory utilization -0.02 [-0.06, +0.03] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.31, +0.18] 1 Logs
otel_to_otel_logs ingress throughput -0.18 [-0.99, +0.63] 1 Logs
basic_py_check % cpu utilization -0.28 [-4.22, +3.66] 1 Logs
idle_all_features memory utilization -0.82 [-0.92, -0.72] 1 Logs bounds checks dashboard
file_tree memory utilization -0.84 [-0.96, -0.71] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.61 [-2.34, -0.88] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10 bounds checks dashboard
idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-mergequeue dd-mergequeue bot merged commit 0c16d90 into 7.60.x Dec 13, 2024
218 of 229 checks passed
@dd-mergequeue dd-mergequeue bot deleted the celian/modules-7.60.x-updated branch December 13, 2024 12:43
@github-actions github-actions bot added this to the 7.60.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants