(fleet) stop the previous installer/agent version on an upgrade

[arbll]

On upgrades we were not restarting the units and instead kept the previous ones running.

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7ca4539f-3217-4563-a3e6-083ed7962efd

Baseline: 777de39
Comparison: d068724
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+2.05	[+1.93, +2.18]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.27	[-0.46, +0.99]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.24	[-0.39, +0.88]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.11	[-2.81, +3.04]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.74, +0.74]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.11, +0.11]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.00	[-0.80, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.76, +0.74]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.79, +0.72]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.04	[-0.91, +0.83]	1	Logs
➖	quality_gate_idle	memory utilization	-0.21	[-0.25, -0.17]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.34	[-0.80, +0.12]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.45	[-0.52, -0.39]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.50	[-1.26, +0.27]	1	Logs
➖	file_tree	memory utilization	-0.79	[-0.92, -0.67]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.88	[-1.54, -0.21]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Package size comparison

Comparison with ancestor 777de397e7d5c10596b60bcbcbbec36be1c94d52

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	-0.00MB	✅	1268.85MB	1268.86MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.28MB	113.28MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.52MB	78.52MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	505.42MB	505.42MB	70.00MB
datadog-agent-x86_64-rpm	-0.00MB	✅	1278.09MB	1278.09MB	140.00MB
datadog-agent-x86_64-suse	-0.00MB	✅	1278.09MB	1278.09MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.35MB	113.35MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.35MB	113.35MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.59MB	78.59MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.59MB	78.59MB	10.00MB
datadog-agent-arm64-deb	-0.00MB	✅	1003.94MB	1003.94MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.76MB	108.76MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.74MB	55.74MB	10.00MB
datadog-agent-aarch64-rpm	-0.00MB	✅	1013.15MB	1013.15MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.83MB	108.83MB	10.00MB

Decision

✅ Passed

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51145410 --os-family=ubuntu

Note: This applies to commit d068724