Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Don't log network_process.enabled by default #32172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pimlu
Copy link
Contributor

@pimlu pimlu commented Dec 13, 2024

What does this PR do?

network_process.enabled is true by default - changes this config to be logged when it is false (instead of the default).

Motivation

Reduce spurious logging from config.New() during tests.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@pimlu pimlu marked this pull request as ready for review December 13, 2024 20:59
@pimlu pimlu requested a review from a team as a code owner December 13, 2024 20:59
@pimlu pimlu requested a review from mbakht December 13, 2024 20:59
@github-actions github-actions bot added team/networks short review PR is simple enough to be reviewed quickly labels Dec 13, 2024
@pimlu pimlu added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 13, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51128103 --os-family=ubuntu

Note: This applies to commit 991ac73

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor e87eaecb8358a40207a043f80e85cc173500a992

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1268.87MB 1268.87MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1278.10MB 1278.10MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1278.10MB 1278.10MB 140.00MB
datadog-agent-arm64-deb 0.00MB 1003.93MB 1003.93MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 1013.15MB 1013.15MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.52MB 78.52MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.74MB 55.74MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.42MB 505.42MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.28MB 113.28MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.76MB 108.76MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.83MB 108.83MB 10.00MB

Decision

✅ Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants