Move SetupCoreDump to pkg/util/coredump to remove deps from trace-agent #32174
Conversation
pgimalac
added
changelog/no-changelog
team/agent-shared-components
qa/done
github-actions
bot
added
component/system-probe
medium review
Go Package Import DifferencesThis comment was omitted because it was over 65,536 characters. Please check the Gitlab Job logs to see its output. |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 786bce8 Optimization Goals: ✅ Improvement(s) detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +0.79 | [+0.11, +1.48] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.78 | [+0.72, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.13 | [-0.75, +1.02] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.10 | [-0.53, +0.73] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.85, +0.89] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.74, +0.77] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.08, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.68, +0.69] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.01 | [-0.83, +0.80] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.01 | [-0.47, +0.45] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.27 | [-1.06, +0.53] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.39 | [-1.12, +0.33] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.61 | [-4.52, +1.30] | 1 | Logs |
| ➖ | file_tree | memory utilization | -2.72 | [-2.84, -2.59] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -3.53 | [-3.67, -3.40] | 1 | Logs bounds checks dashboard |
| ✅ | quality_gate_idle | memory utilization | -5.79 | [-5.83, -5.74] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51139157 --os-family=ubuntuNote: This applies to commit d1498b2 |
What does this PR do?
Split the
SetupCoreDumpfunction frompkg/utiltopkg/util/coredump.Motivation
Remove dependencies from the trace-agent.
Describe how you validated your changes
There should be no functional changes, this only moves a function to another package.
Possible Drawbacks / Trade-offs
Additional Notes
This removes ~570 dependencies from the trace-agent, resulting in around 35MB binary size reduction, more than 50% of the trace-agent binary size (from 65MB to 30MB).