Fix Boto HTTP proxy configuration #3722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boto's proxy argument don't want the protocol on the proxy host. Configuration within Datadog itself requires this protocol, so strip it before we pass the proxy host to Boto. Signed-off-by: Margarita Sokolova <margarita.sokolova@getbraintree.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes Boto's HTTP proxy configuration within the agent.
Boto's proxy argument don't want the protocol on the proxy host.
Configuration within Datadog itself requires this protocol, so strip it
before we pass the proxy host to Boto.
Motivation
We need to proxy our dd-agent traffic out via a HTTP proxy. After configuring the HTTP proxy for the dd-agent we noticed it started failing to retrieve EC2 tags from the AWS API. We tracked the issue down to this misconfigured Boto proxy argument.
We've deployed this fix and seen the dd-agent successfully fetch tags via an HTTP proxy.