Make plugin compatible with Kotlin Script #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
previously approved these changes
Oct 10, 2023
buildSrc/src/main/kotlin/com/datadog/gradle/config/MavenConfig.kt
Outdated
Show resolved
Hide resolved
xgouchet
force-pushed
the
xgouchet/154/kotlin_dsl
branch
from
13d65ab to
54d3d8a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #197 +/- ##
=============================================
- Coverage 86.70% 86.25% -0.45%
- Complexity 177 178 +1
=============================================
Files 21 21
Lines 579 582 +3
Branches 76 76
=============================================
Hits 502 502
- Misses 49 53 +4
+ Partials 28 27 -1
|
0xnm
approved these changes
Oct 10, 2023
|
@0xnm when this fix will be released? It would be great to add it ASAP, and remove my hacky way to support different service name depending of variants |
|
Hello @KamilPieta! Please check version 1.12.0 of our plugin, which has change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds configuration DSL to easily setup the plugin when using Kotlin Script
Motivation
Fixes #154