fix: Standardize architectures #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
approved these changes
Apr 22, 2024
0xnm
approved these changes
Apr 22, 2024
Comment on lines
+85
to
+90
| internal val SUPPORTED_ARCHS = setOf( | ||
| SupportedArchitectureMapping("armeabi-v7a", "arm"), | ||
| SupportedArchitectureMapping("arm64-v8a", "arm64"), | ||
| SupportedArchitectureMapping("x86", "x86"), | ||
| SupportedArchitectureMapping("x86_64", "x64") | ||
| ) |
There was a problem hiding this comment.
Sounds like could be simply mapOf<String, String>, without introducing data class. But not a big deal.
There was a problem hiding this comment.
Yeah, I was curious about that. I could go either way but I figured the data class was more descriptive.
There was a problem hiding this comment.
just lookup is now linear instead of O(1), but it doesn't really matter here
fuzzybinary
force-pushed
the
jward/standardize-arch
branch
from
1773de1 to
5764026
Compare
The symbolication service currently understands `arm`, `arm64`, `x86` and `x64` as valid symbol file architectures. Instead of adding the Android ABIs, we map them to those architectures instead.
fuzzybinary
force-pushed
the
jward/standardize-arch
branch
from
5764026 to
bb01f6f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #249 +/- ##
=============================================
+ Coverage 81.30% 81.73% +0.43%
- Complexity 203 205 +2
=============================================
Files 26 26
Lines 802 810 +8
Branches 104 104
=============================================
+ Hits 652 662 +10
Misses 112 112
+ Partials 38 36 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The symbolication service currently understands
arm,arm64,x86andx64as valid symbol file architectures. Instead of adding the Android ABIs, we map them to those architectures instead.Review checklist (to be filled by reviewers)