Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4292: Mark upload task as not compatible with configuration cache #256

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented May 3, 2024

What does this PR do?

This PR will mark upload task as not compatible with configuration cache, meaning it won't be recorded for the configuration cache.

This fixes the issue #251.

Note, that we may come back to the configuration cache support for this task in the future, but for now the issue is that task input expects build ID file to be present, and it will be present only after build run, not at the configuration phase. Complete configuration cache support thus will require major logic changes, which may be not worth it, considering that configuration for this task is very fast.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners May 3, 2024 12:57
@0xnm 0xnm force-pushed the nogorodnikov/rum-4292/solve-compatibility-of-upload-task-with-configuration-cache branch from 607c06e to c7360f4 Compare May 3, 2024 12:58
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.75%. Comparing base (c3626c4) to head (c7360f4).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #256      +/-   ##
=============================================
- Coverage      80.78%   80.75%   -0.03%     
- Complexity       205      206       +1     
=============================================
  Files             26       26              
  Lines            822      826       +4     
  Branches         105      108       +3     
=============================================
+ Hits             664      667       +3     
+ Misses           121      114       -7     
- Partials          37       45       +8     
Files Coverage Δ
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 68.82% <66.67%> (-0.04%) ⬇️
...in/kotlin/com/datadog/gradle/plugin/DdTaskUtils.kt 68.18% <37.50%> (+6.28%) ⬆️

... and 1 file with indirect coverage changes

Base automatically changed from nogorodnikov/rum-4374/emulate-upload-call-for-functional-tests to develop May 6, 2024 06:51
@0xnm 0xnm merged commit db3ff0d into develop May 6, 2024
12 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-4292/solve-compatibility-of-upload-task-with-configuration-cache branch May 6, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants