Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-4594] Increase upload timeout to 120s to match EvP limits #261

Merged
merged 1 commit into from
May 22, 2024

Conversation

plousada
Copy link
Member

What does this PR do?

This PR increases the upload timeout limit from 60s to 120s in all DCs. This change was made in order to support customers with slower upload speeds.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@plousada plousada requested review from a team as code owners May 22, 2024 11:26
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (9834378) to head (3ca03e6).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #261   +/-   ##
==========================================
  Coverage      80.43%   80.43%           
  Complexity       209      209           
==========================================
  Files             26       26           
  Lines            828      828           
  Branches         110      110           
==========================================
  Hits             666      666           
  Misses           116      116           
  Partials          46       46           
Files Coverage Δ
...m/datadog/gradle/plugin/internal/OkHttpUploader.kt 78.20% <100.00%> (ø)

... and 2 files with indirect coverage changes

@plousada plousada merged commit 7cd2c7d into develop May 22, 2024
13 checks passed
@plousada plousada deleted the plousada/RUM-4594/increase-upload-time-limit-120s branch May 22, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants