Send tracestate with w3c headers by default #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Printed headers from a httpbin call (not sampled/sampled): |
ganeshnj
reviewed
Nov 6, 2023
| isSampled: | ||
| tracingAttributes.samplingPriorityHeader === '1' | ||
| }) | ||
| } |
There was a problem hiding this comment.
Like I have been asking everyone, can you make sure that data in the datadog headers is same as tracecontext headers?
A test on it would be much appreciated if these isn't one.
louiszawadzki
force-pushed
the
louiszawadzki/rum-1926/send-tracestate-with-w3c-headers
branch
from
47c7fbd to
da4aec7
Compare
louiszawadzki
force-pushed
the
louiszawadzki/rum-1926/send-tracestate-with-w3c-headers
branch
from
da4aec7 to
6608975
Compare
ganeshnj
approved these changes
Nov 7, 2023
louiszawadzki
deleted the
louiszawadzki/rum-1926/send-tracestate-with-w3c-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Review checklist (to be filled by reviewers)