Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-5418] Add RN API to append to existing user info #726

Conversation

mateo-villa
Copy link
Contributor

@mateo-villa mateo-villa commented Oct 5, 2024

What does this PR do?

Adds an addUserExtraInfo API to append user info to an existing user.

Motivation

RUM-5418

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@mateo-villa mateo-villa requested a review from a team as a code owner October 5, 2024 22:29
@mateo-villa mateo-villa force-pushed the mateo-villa/RUM-5418/add-extra-user-info branch from 1e39862 to 29798b2 Compare October 5, 2024 22:43
@mateo-villa mateo-villa force-pushed the mateo-villa/RUM-5418/add-extra-user-info branch from 29798b2 to 510d255 Compare October 5, 2024 22:54
Copy link
Member

@marco-saia-datadog marco-saia-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! It looks good to me.

The only thing missing is adding addUserExtraInfo to the DdSdkReactNative mock. It is currently making the build fail.

FAIL packages/core/src/__tests__/mock.test.ts
  ● official mock › mocks module: { DdSdkReactNative: [Function] } › for key: addUserExtraInfo
    expect(received).not.toBeUndefined()
    Received: undefined
      73 |                 'for key: %s',
      74 |                 key => {
    > 75 |                     expect(mock[moduleName][key]).not.toBeUndefined();
         |                                                       ^
      76 |                 }
      77 |             );
      78 |         }
      at toBeUndefined (src/__tests__/mock.test.ts:75:55)

@mateo-villa mateo-villa force-pushed the mateo-villa/RUM-5418/add-extra-user-info branch from 062bd69 to eae542b Compare October 7, 2024 14:52
@marco-saia-datadog marco-saia-datadog merged commit 774e0f9 into DataDog:develop Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants