Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose method generateUUID in DdRUM #746

Closed
wants to merge 1 commit into from
Closed

Expose method generateUUID in DdRUM #746

wants to merge 1 commit into from

Conversation

jhssilva
Copy link
Contributor

@jhssilva jhssilva commented Dec 9, 2024

What it does?

  • Exposes the generateUUID in DdRUM.

Motivation

  • If a user wants to generate an trace/span id on the headers to custom inject, it will require to generate a uid that complies with trace context propagation. This change will enable to easily retrieve the UID.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@jhssilva jhssilva requested a review from a team as a code owner December 9, 2024 17:12
marco-saia-datadog
marco-saia-datadog approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@marco-saia-datadog marco-saia-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@marco-saia-datadog marco-saia-datadog mentioned this pull request Dec 16, 2024
Merged
4 tasks
@marco-saia-datadog
Copy link
Member

I have created another PR #749 for signing the commit and running checks ✅

@marco-saia-datadog marco-saia-datadog added the Do not merge This PR is not ready to be merged yet label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-saia-datadog marco-saia-datadog marco-saia-datadog approved these changes

Assignees
No one assigned
Labels
Do not merge This PR is not ready to be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhssilva @marco-saia-datadog