[RUM-6028, 0.75 Support] DrawableUtils based on RN version #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
0xnm
approved these changes
Dec 17, 2024
...id/src/test/kotlin/com/datadog/reactnative/sessionreplay/mappers/ReactViewGroupMapperTest.kt
Outdated
Show resolved
Hide resolved
marco-saia-datadog
force-pushed
the
marcosaia/RUM-6028/sr-rn-75-support
branch
from
f4e0644 to
caf4235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Conditionally builds different DrawableUtils for different RN versions, to grant compatibility with RN 0.75+.
Motivation
ReactViewImageBackgroundDrawablewas deprecated in version 0.75 and has already been removed in developCSSBackgroundDrawablehas been introduced in its place (and it is currently marked as unstable, so it could change in the future)Since Session Replay heavily relies on React Native classes, and they can change significantly between different versions, this PR aims to introduce version-specific source sets in the form of:
rn[version]: classes for specific minor versions of RNrnlegacy: classes for all previous versionsThe naming and folder structure can be changed.
Review checklist (to be filled by reviewers)