Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/uptrace/bun: initial implementation #2771

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Conversation

darccio
Copy link
Member

@darccio darccio commented Jul 4, 2024

What does this PR do?

Integrates github.com/uptrace/bun ORM to generate query spans.

Motivation

  • It's used by significant customers.
  • It has a similar popularity than go-pg. bun is a rewrite of go-pg using database/sql.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jul 4, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 4, 2024

Benchmarks

Benchmark execution time: 2024-07-05 09:54:43

Comparing candidate commit 33f5b50 in PR branch dario.castane/bun-contrib with baseline commit fcda398 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 0 unstable metrics.

contrib/uptrace/bun/bun_test.go Outdated Show resolved Hide resolved
contrib/uptrace/bun/bun_test.go Show resolved Hide resolved
contrib/uptrace/bun/bun_test.go Outdated Show resolved Hide resolved
contrib/uptrace/bun/bun_test.go Outdated Show resolved Hide resolved
contrib/uptrace/bun/option.go Show resolved Hide resolved
contrib/uptrace/bun/option.go Outdated Show resolved Hide resolved
contrib/uptrace/bun/example_test.go Show resolved Hide resolved
contrib/uptrace/bun/bun.go Outdated Show resolved Hide resolved
@darccio darccio marked this pull request as ready for review July 5, 2024 09:33
@darccio darccio requested review from a team as code owners July 5, 2024 09:33
Copy link
Contributor

@rarguelloF rarguelloF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darccio darccio merged commit 891aad4 into main Jul 8, 2024
195 of 196 checks passed
@darccio darccio deleted the dario.castane/bun-contrib branch July 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants