Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade golangci-lint 1.52.2 -> 1.59.1 #2777

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

eliottness
Copy link
Contributor

What does this PR do?

Upgrade golangci-lint version in CI

Motivation

It is built with an legacy version of go (1.20) which breaks new compilation features of go 1.21
cf. this job

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness force-pushed the eliott.bouhana/upgrade-golangci-lint branch from 3229cdf to 1177629 Compare July 8, 2024 15:06
@eliottness eliottness marked this pull request as ready for review July 8, 2024 15:14
@eliottness eliottness requested a review from a team as a code owner July 8, 2024 15:14
@eliottness eliottness merged commit fe89caa into main Jul 8, 2024
163 of 164 checks passed
@eliottness eliottness deleted the eliott.bouhana/upgrade-golangci-lint branch July 8, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants