-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appsec: setup ossec package and OpenOperation #2781
Conversation
BenchmarksBenchmark execution time: 2024-08-16 13:03:48 Comparing candidate commit 465bb69 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 1 unstable metrics. scenario:BenchmarkStartRequestSpan-24
|
68fe39e
to
c3342d8
Compare
c3342d8
to
f0db6f9
Compare
f0db6f9
to
a6344bf
Compare
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
104538f
to
4e7459c
Compare
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
7a9527d
to
71f22a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Modulo the still open conversation :)
…er + refactor OpenOperationRes Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
### What does this PR do? This PR instrument all file opening via the `os.Openfile` function for RASP LFI and is the sister PR of DataDog/dd-trace-go#2781 - [x] Write intrumentation file - [x] Write integration tests for the `os` package - [x] Add `tracer-internal: true` to the `dd:orchestrion-enabled` instrumentation to properly enable the GLS storage in dd-trace-go - [x] Add more tests for `dd:orchestrion-enabled` ### Motivation Support for LFI protection. ### Reviewer's Checklist <!-- * Authors can use this list as a reference to ensure that there are no problems during the review but the signing off is to be done by the reviewer(s). --> - [ ] Changed code has unit tests for its functionality. --------- Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
What does this PR do?
This PR setups protection against LFI attacks:
ossec
listener with the new address and register the listener where it is neededossec
emitter package with the newOpenOperation
<generated>
runs-on
parameterMotivation
Complete support for ASM Exploit Prevention.
Reviewer's Checklist
Unsure? Have a question? Request a review!
Signed-off-by: Eliott Bouhana eliott.bouhana@datadoghq.com