Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: retract experimental versions #2806

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

darccio
Copy link
Member

@darccio darccio commented Aug 5, 2024

What does this PR do?

Retracts some tagged versions created to dogfood our v1 shim for v2.

Motivation

Keep public docs clean and let users to use release candidates if they want without go get pulling the experimental versions accidentally.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Aug 5, 2024

Benchmarks

Benchmark execution time: 2024-08-05 10:22:07

Comparing candidate commit c9f2fbd in PR branch dario.castane/retract-experimental-versions with baseline commit 794b629 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@darccio darccio requested a review from a team August 5, 2024 12:20
@nsrip-dd
Copy link
Contributor

nsrip-dd commented Aug 5, 2024

@darccio
Copy link
Member Author

darccio commented Aug 5, 2024

With this PR, we won't need the hack in the Orchestrion CI, right? DataDog/orchestrion@6feff0e/.github/workflows/deps-update.yml#L28-L35

Indeed, it won't be more needed.

@darccio darccio merged commit 908da63 into main Aug 5, 2024
185 checks passed
@darccio darccio deleted the dario.castane/retract-experimental-versions branch August 5, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants