profiler: record Orchestrion, activation information #2814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For tracking adoption of SSI for profiling, record whether the profiler
was added using Orchestrion and how the profiler was activated,
following the internal "Adding SSI information to profiles" RFC.
The tests aren't great for this. I'm working on a more end-to-end test which
builds an app with Orchestrion, enables the profiler, and checks the contents of
the profile, possibly using our profiling-backend-in-a-box. In the mean time,
I ran the new test with Orchestrion to confirm that the "mechanism" is set:
Motivation
To track Orchestrion adoption in the same way that we'll track SSI adoption for
other languages/runtimes.