Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/appsec: fix missing ResponseHeaderCopier call #2841

Merged

Conversation

eliottness
Copy link
Contributor

What does this PR do?

This PR fixes a case where we were supposed to call the ResponseHeaderCopier func but we did not

Motivation

Fix cases where concurrently reading the response header map would can a panic. This fixes the fix done in #2640

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness requested a review from a team as a code owner September 2, 2024 11:34
@eliottness eliottness self-assigned this Sep 2, 2024
@eliottness eliottness enabled auto-merge (squash) September 2, 2024 11:34
@pr-commenter
Copy link

pr-commenter bot commented Sep 2, 2024

Benchmarks

Benchmark execution time: 2024-09-02 11:56:28

Comparing candidate commit e9c5570 in PR branch eliott.bouhana/fix-missing-response-header-copier-call with baseline commit e7ca17e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@eliottness eliottness merged commit 2c85bdc into main Sep 2, 2024
186 checks passed
@eliottness eliottness deleted the eliott.bouhana/fix-missing-response-header-copier-call branch September 2, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants