-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(.github/workflows): add tags-ignore to avoid running CI on pushing tags for contribs and other nested modules #3005
base: main
Are you sure you want to change the base?
Conversation
034574c
to
74620b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dd-trace-go@v2 has 50+ tags per release, so pushing them generate a lot of workload in CI.
If I understand correctly, this is because there will be seperate modules for each contrib/integration, which we need to tag seperately? But the tags will all point to the same code, right? If so, definitely makes sense not to run redundant CI on those tags.
tags-ignore: | ||
- 'contrib/**' | ||
- 'instrumentation/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these checks would still run on all PRs, but not for each pushed tag, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly.
Datadog ReportBranch report: ✅ 0 Failed, 5094 Passed, 67 Skipped, 2m 29.74s Total Time |
Indeed, @nsrip-dd, this is the case. Although the process involves tagging and pushing tags in three phases (1, tag the root module; 2, tag contribs that are imported by other contribs; 3, tagging the rest of modules), they are the same code altogether ( Also, all the code is already tested in the PRs, nightlies, etc. |
BenchmarksBenchmark execution time: 2024-12-04 16:12:20 Comparing candidate commit 74620b4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
What does this PR do?
Adding
tags-ignore
to all GitHub Actions' workflows so they don't run when pushing tags.Motivation
dd-trace-go@v2
has 50+ tags per release, so pushing them generate a lot of workload in CI.Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!