Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/log/slog: test with slogtest #3018

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

felixge
Copy link
Member

@felixge felixge commented Dec 9, 2024

What does this PR do?

Use slogtest to ensure that WrapHandler is behaving correctly. This was already the case, so this patch is merely adding additional confidence in the correctness.

Motivation

I didn't know about the slogtest package and just discovered it while looking into something else. So I figured I check if our implementation passes the tests.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

Use slogtest to ensure that WrapHandler is behaving correctly. This was
already the case, so this patch is merely adding additional confidence
in the correctness.
@felixge felixge requested review from a team as code owners December 9, 2024 07:38
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Dec 9, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2024

Benchmarks

Benchmark execution time: 2024-12-09 16:16:12

Comparing candidate commit e2f9705 in PR branch felix.geisendoerfer/slog-test with baseline commit 7f02289 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@felixge felixge enabled auto-merge (squash) December 9, 2024 15:32
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: felix.geisendoerfer/slog-test
Commit report: e170541
Test service: dd-trace-go

✅ 0 Failed, 2981 Passed, 24 Skipped, 2m 26.31s Total Time

@felixge felixge merged commit 2276949 into main Dec 11, 2024
160 of 161 checks passed
@felixge felixge deleted the felix.geisendoerfer/slog-test branch December 11, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants