Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix(ddtrace/tracer): Disable agent features and remote configuration in CI Visibility agentless mode #3027

Open
wants to merge 1 commit into
base: v2-dev
Choose a base branch
from

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Dec 10, 2024

What does this PR do?

This PR disables the agent features request and the remote configuration if the tracer was loaded in CI Visibility agentless mode.

v1: #3026

Ticket: SDTEST-1321

Motivation

In agentless mode we don't use an agent so those features are not available.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 10, 2024

Datadog Report

Branch report: tony/civisibility-improve-startup-v2
Commit report: 0ac64a8
Test service: dd-trace-go

✅ 0 Failed, 4048 Passed, 61 Skipped, 2m 45.35s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2024

Benchmarks

Benchmark execution time: 2024-12-10 23:06:32

Comparing candidate commit 9159627 in PR branch tony/civisibility-improve-startup-v2 with baseline commit e6a87da in branch v2-dev.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 52 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagMetric-24

  • 🟥 execution_time [+3.880ns; +6.720ns] or [+3.280%; +5.680%]

@tonyredondo tonyredondo marked this pull request as ready for review December 11, 2024 13:18
@tonyredondo tonyredondo requested a review from a team as a code owner December 11, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants