-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commit check job #4408
Add commit check job #4408
Conversation
Overall package sizeSelf size: 6.71 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-06-18 03:24:54 Comparing candidate commit 4837f2f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 7 unstable metrics. scenario:plugin-graphql-with-depth-on-max-18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to address, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, this isn't the right approach.
We shouldn't care whether PR branches have merge commits on them. We should care whether those end up on master, but that's part of the larger problem of not being able to enforce squash-merges only, because we also need rebase-merges for releases. This isn't the right solution to that though.
What does this PR do?
Adds a check to validate a PR does not contain merge commits
Motivation
A recent change landed without being squashed because changes from master were merged back to the PR. Merge commits should never be present given that we are supposed to always use squash to land feature PRs and rebase to land release proposal PRs.