Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling when span id and trace id are undefined #4884

Closed
wants to merge 6 commits into from

Conversation

ida613
Copy link
Collaborator

@ida613 ida613 commented Nov 13, 2024

What does this PR do?

When we only propagate baggage and nothing else, trace id and span id could be undefined. This PR adds handling for this case. According to otel specification, baggages are attached to contexts rather than spans, but contexts are tied to spans in dd-trace-js. We are essentially using spans to propagate baggages, so trace id and span id could be missing.

Motivation

Plugin Checklist

Additional Notes

@ida613 ida613 requested a review from a team as a code owner November 13, 2024 17:41
Copy link

github-actions bot commented Nov 13, 2024

Overall package size

Self size: 8.03 MB
Deduped: 94.54 MB
No deduping: 94.88 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-14 04:03:44

Comparing candidate commit b734a0a in PR branch ida613/baggage-patch2 with baseline commit 36903cc in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

@ida613 ida613 marked this pull request as draft November 13, 2024 21:20
@ida613 ida613 changed the title do not inject baggage items when they exceed limits Handle when span id and trace id are undefined Nov 14, 2024
@ida613 ida613 changed the title Handle when span id and trace id are undefined Add handling when span id and trace id are undefined Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (0b4dab7) to head (b734a0a).
Report is 36 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4884       +/-   ##
===========================================
- Coverage   93.86%   75.45%   -18.42%     
===========================================
  Files         107      325      +218     
  Lines        3373    14791    +11418     
===========================================
+ Hits         3166    11160     +7994     
- Misses        207     3631     +3424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ida613 ida613 marked this pull request as ready for review November 14, 2024 03:59
@ida613 ida613 closed this Nov 19, 2024
@ida613 ida613 reopened this Nov 19, 2024
@ida613 ida613 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants