Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Add support for sampling #4998

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[DI] Add support for sampling #4998

merged 1 commit into from
Dec 12, 2024

Conversation

watson
Copy link
Collaborator

@watson watson commented Dec 11, 2024

Not included in this PR:

  • Support for a global max sample rate across multiple probes

Copy link
Collaborator Author

watson commented Dec 11, 2024

Copy link

github-actions bot commented Dec 11, 2024

Overall package size

Self size: 8.24 MB
Deduped: 94.81 MB
No deduping: 95.37 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.0 | 2.58 MB | 2.72 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (watson/DEBUG-2614/dynamic-breakpoint-url@a50d854). Learn more about missing BASE report.

Additional details and impacted files
@@                             Coverage Diff                             @@
##             watson/DEBUG-2614/dynamic-breakpoint-url    #4998   +/-   ##
===========================================================================
  Coverage                                            ?   65.89%           
===========================================================================
  Files                                               ?       14           
  Lines                                               ?      909           
  Branches                                            ?        0           
===========================================================================
  Hits                                                ?      599           
  Misses                                              ?      310           
  Partials                                            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks

Benchmark execution time: 2024-12-12 13:04:29

Comparing candidate commit 1fa77b3 in PR branch watson/DEBUG-2614/sampling with baseline commit 04f3610 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 263 metrics, 3 unstable metrics.

@watson watson force-pushed the watson/DEBUG-2614/dynamic-breakpoint-url branch from 87a98ad to aa7562e Compare December 11, 2024 17:36
@watson watson force-pushed the watson/DEBUG-2614/sampling branch 2 times, most recently from da0fc35 to acbba64 Compare December 12, 2024 07:04
Base automatically changed from watson/DEBUG-2614/dynamic-breakpoint-url to master December 12, 2024 12:51
@watson watson marked this pull request as ready for review December 12, 2024 12:53
@watson watson requested review from a team as code owners December 12, 2024 12:53
@watson watson force-pushed the watson/DEBUG-2614/sampling branch from acbba64 to 1fa77b3 Compare December 12, 2024 12:54
@watson watson merged commit de0b516 into master Dec 12, 2024
292 checks passed
@watson watson deleted the watson/DEBUG-2614/sampling branch December 12, 2024 18:24
@rochdev rochdev mentioned this pull request Dec 17, 2024
rochdev pushed a commit that referenced this pull request Dec 17, 2024
@rochdev rochdev mentioned this pull request Dec 17, 2024
rochdev pushed a commit that referenced this pull request Dec 17, 2024
rochdev pushed a commit that referenced this pull request Dec 18, 2024
rochdev pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants