DBM: Add option to SQL comment propagation #5125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas
force-pushed
the
pg-append-comment
branch
from
6334613 to
eb67650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a port of DataDog/dd-trace-rb#3809 to
dd-trace-js.It adds an option to append the DBM trace propagation comment instead, of prepending it. This allow users using database monitor tools to see the SQL query itself first, instead of the Datadog trace propagation comment first.
Motivation
External tools, such as AWS RDS Performance Insights, are very hard to use with DBM comments prepended.
Further, it's currently impossible to use pg_hint_plan when
dd-trace-jsprefixes queries with a comment.Plugin Checklist
API documentation.Additional Notes