v4.56.0 proposal #5139
Closed
v4.56.0 proposal #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed in order for CI to validate the following upcoming new config options: - `dynamicInstrumentationRedactedIdentifiers` - `dynamicInstrumentationRedactionExcludedIdentifiers`
The algorithm will look for:
- names of variables
- names of object properties
- names of keys in maps
The names will be matched against a disallow-list and if a match is
found, its value will be redacted.
The list is hardcoded and can be found here:
packages/dd-trace/src/debugger/devtools_client/snapshot/redaction.js
It's possible to add names to the list using the following environment
variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTED_IDENTIFIERS
Or it's possible to remove names from the list using the following
environment variable:
DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS
Each environment variable takes a list of names separated by commas.
Support for redacting instances of specific classes is not included in
this commit.
* K8s new scenarios
This affects all DI related config options, where the `experimental` namespace is removed and, and a `dynamicInstrumentation` namespace is introduced. Changes: - `experimental.dynamicInstrumentationEnabled` -> `dynamicInstrumentation.enabled` - `experimental.dynamicInstrumentationRedactedIdentifiers` -> `dynamicInstrumentation.redactedIdentifiers` - `experimental.dynamicInstrumentationRedactionExcludedIdentifiers` -> `dynamicInstrumentation.redactionExcludedIdentifiers`
* Initial APM side for aws bedrock * add extract response tags * add extract response tags * remove hook * Update packages/datadog-plugin-aws-sdk/src/services/bedrockruntime.js * added example test for invoke amazon * added example test for invoke amazon * update test with todos * update test with todos * Drop underscore in name * Update packages/datadog-plugin-aws-sdk/test/bedrock.spec.js Co-authored-by: Sam Brenner <106700075+sabrenner@users.noreply.github.com> * Constants normalization * Add Mistral AI * Add aws bedrock rec * remove file * added tests with mocked responses * added jamba support to AI21 lab * update bedrock version * Update tests * remove only * Update response extractions to only pick up first completion/generation * Update packages/datadog-plugin-aws-sdk/src/services/bedrockruntime.js Co-authored-by: Sam Brenner <106700075+sabrenner@users.noreply.github.com> * Change from constants to a struct for model provider * format * switch case * Add classes for generations and requestParams * Make constructors name object based. and stringify prompt if it's not a string * stringify message if it's not a string * es lint * fix bad variable name * add extra tags * camelCase and lint * camelCase and lint --------- Co-authored-by: Sam Brenner <106700075+sabrenner@users.noreply.github.com>
Each enhanced log probe has a sample rate of one second. However, too many individual probes might still overload the system, so a global snapshot sample rate across all enhanced log probes is required.
…number of CPU cores (#5099) * Fix how balancing over CPU cores works, so now tasks are split by variants instead of only directories * Fix bug with taskset trying to assign to non-existing core * Fix bug with off by 1 error in benchmarks count * Fail job with exit code 1 if sirun could not start it * Fail CI job when GROUP_SIZE is larger than number of CPU cores
…y tags (#5102) * wip * get rid of unecessary test
#5072) Co-authored-by: Thomas Watson <w@tson.dk>
* llmobs langchain plugin * starting test changes * refactor llmobs langchain plugin to use handlers * wip * finish adding most tests * higher timeout ts tests * add missing tests * change lowerbound node version for langchain test to 18 * add cohere test for newer versions * add externals * add error tests * more consistent parentage behavior * review comments
* Upgrade upload-artifact version * disable integration test for vitest v3 for now --------- Co-authored-by: Bryan English <bryan.english@datadoghq.com>
Some dependencies don't work correctly with `require` anymore.
* Untrusted deserialization vulnerability detection * use node-serialize most used version * fix sorting sensitive analyzers * remove DB source
* Instrument vm for code injection vulnerability * simplify vm constructor instrumentation * support SourceTextModule class * add code injection integration test * instrument SourceTextModule only if it's enabled * unify channel arguments
Enables tracing header injection on AWS signed requests and fixes problem causing InvalidSignatureException.
Someone forgot to check in updates to yarn.lock the last time package.json was updated.
Queue the probe EMITTING status before trying to queue the probe payload. Before, the EMITTING status was only emitted if the probe payload was successfully received by the agnet. If the agent didn't return a HTTP 2xx status code, the EMITTING status would never be sent.
* typo * use range_clean * use range_clean also for aerospike
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| env: | ||
| PLUGINS: langchain | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
Overall package sizeSelf size: 8.49 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.x #5139 +/- ##
=======================================
Coverage ? 98.13%
=======================================
Files ? 1
Lines ? 107
Branches ? 0
=======================================
Hits ? 105
Misses ? 2
Partials ? 0 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-01-22 12:18:59 Comparing candidate commit 6166775 in PR branch Found 9 performance improvements and 27 performance regressions! Performance is the same for 1004 metrics, 24 unstable metrics. scenario:appsec-control-16
scenario:appsec-control-18
scenario:appsec-control-20
scenario:appsec-control-22
scenario:appsec-iast-no-vulnerability-control-16
scenario:appsec-iast-no-vulnerability-control-18
scenario:appsec-iast-no-vulnerability-control-20
scenario:appsec-iast-no-vulnerability-control-22
scenario:net-control-20
scenario:plugin-http-server-control-16
scenario:plugin-http-server-control-18
scenario:plugin-http-server-control-20
scenario:plugin-http-server-control-22
scenario:scope-manager-async_hooks-16
scenario:scope-manager-async_hooks-18
scenario:scope-manager-async_hooks-20
scenario:scope-manager-async_hooks-22
scenario:scope-manager-async_local_storage-16
scenario:scope-manager-async_local_storage-18
scenario:scope-manager-async_local_storage-20
scenario:scope-manager-async_local_storage-22
scenario:scope-manager-async_resource-16
scenario:scope-manager-async_resource-18
scenario:scope-manager-async_resource-20
scenario:scope-manager-async_resource-22
scenario:scope-manager-base-16
scenario:scope-manager-base-18
scenario:scope-manager-base-20
scenario:scope-manager-base-22
|
watson
force-pushed
the
v4.56.0-proposal
branch
from
6166775 to
4c0173c
Compare
|
Closing as we're dropping support for 4.x now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
504b460bbf] - (SEMVER-PATCH) add SSI + K8s to version support matrix (Bryan English) #50889c1a2fac84] - (SEMVER-PATCH) Revert "fix aws-sdk invalid signature exception (inject cloned request headers for signed aws-sdk requests #5127)" (Thomas Watson) #514151e63506ba] - (SEMVER-PATCH) [DI] Improve internal caching algorithm resource overhead (Thomas Watson) #4864d9ffb78ec4] - (SEMVER-PATCH) Fix plugins.yml (Igor Unanua) #5121ae0674c6f7] - (SEMVER-PATCH) [DI] Add more debug logs related to queuing and flushing payloads (Thomas Watson) #5130313792a63c] - (SEMVER-PATCH) [bench] exit if results.ndjson is empty (Thomas Watson) #51071310e3bde6] - (SEMVER-PATCH) �[bench] clean up temp files even in case of error (Thomas Watson) #51060d49ecf28c] - (SEMVER-PATCH) [test optimization] Fix ATR + DI issues with jest (Juan Antonio Fernández de Alba) #5136dcf3c7e444] - (SEMVER-PATCH) [test optimization] Fix vitest latest release (Juan Antonio Fernández de Alba) #512334499f3357] - (SEMVER-PATCH) [DI] Ensure probe EMITTING status is sent correctly (Thomas Watson) #5133307f471db7] - (SEMVER-PATCH) [DI] Fix consistency issue with log messages (Thomas Watson) #512906d04734ad] - (SEMVER-PATCH) Ensure yarn.lock matches package.json (Thomas Watson) #51344ef12fc323] - (SEMVER-MINOR) fix aws-sdk invalid signature exception (William Conti) #5127f214673c6e] - (SEMVER-PATCH) use url if provided from DD_TRACE_AGENT_URL (Sam Brenner) #5128015a722c19] - (SEMVER-PATCH) fix AppSec SDK not triggering twice in a row (simon-id) #51153b8a6b9ba2] - (SEMVER-MINOR) Instrument vm for code injection vulnerability (ishabi) #5080c37f47ba82] - (SEMVER-PATCH) [DI] Align PII redaction tokens with the other tracers (Thomas Watson) #5114726cfd697d] - (SEMVER-MINOR) Untrusted deserialization vulnerability detection (ishabi) #5062a77283c06a] - (SEMVER-PATCH) fix startup benchmark (Bryan English) #5120dd63953388] - (SEMVER-PATCH) upgrade upload-artifact version and fix vitest (Igor Unanua) #5118803ac98784] - (SEMVER-PATCH) [Test Optimization] Fix DI setup for jest workers (Juan Antonio Fernández de Alba) #511026722b3080] - (SEMVER-MINOR) Mark crashes that happen during collecting profiles asprofiler_serializing:1(Attila Szegedi) #50966523d94129] - (SEMVER-MINOR) [MLOB-1858] feat(llmobs): langchain submits llmobs span events (Sam Brenner) #492395f82a9232] - (SEMVER-PATCH) [bench] Don't force Node.js 18 for npm/yarn install (Thomas Watson) #5103ff07f4f1d6] - (SEMVER-PATCH) [DI] Add missing PII redaction tokens (Thomas Watson) #5112b070889576] - (SEMVER-MINOR) Add parallelism information to profiles (Attila Szegedi) #47659e36df06dd] - (SEMVER-PATCH) Fix control case for the profiler benchmark (Attila Szegedi) #5108149742b880] - (SEMVER-MINOR) otel drop in support for baggage (Ida Liu) #5019708b62716d] - (SEMVER-PATCH) [bench] detect number of CPU cores dynamically (Thomas Watson) #51046adf12180d] - (SEMVER-PATCH) [bench] minor code-cleanup in the benchmarking script (Thomas Watson) #510571c430729f] - (SEMVER-PATCH) [test optimization] [SDTEST-1355] Fix DI issues with auto test retries (Juan Antonio Fernández de Alba) #5072af641d60ef] - (SEMVER-PATCH) fix(llmobs): tagger reads propogated mlApp and sessionId from registry tags (Sam Brenner) #5102435109b97c] - (SEMVER-PATCH) fix(ci): Balance splits across benchmarking CI jobs according to the number of CPU cores (Dmytro Yurchenko) #5099587957edef] - (SEMVER-PATCH) [DI] Reduce time it takes to run benchmarks (Thomas Watson) #5100684ead6987] - (SEMVER-PATCH) [DI] Add Sirun benchmark for Dynamic Instrumentation (Thomas Watson) #5004f76beab3ad] - (SEMVER-PATCH) Use literals for creating BigInts when possible (Thomas Watson) #5093d73f8cb9df] - (SEMVER-PATCH) [DI] Add a global max snapshot sample rate of 25/second (Thomas Watson) #50814886c38585] - (SEMVER-MINOR) Initial APM side for aws bedrock (yahya-mouman) #493771fc75fae3] - (SEMVER-PATCH) [DI] Ensure probes without a 'sampling' property is parsed correctly (Thomas Watson) #50907e4b054ea7] - (SEMVER-PATCH) DNS Lookup event hostname is sometimes not a string (Attila Szegedi) #5067858b2a1007] - (SEMVER-PATCH) Remove config telemetry normalization tests (Brian Marks) #50826e5d2e8fa6] - (SEMVER-PATCH) [DI] Add namespace to all DI related config options (Thomas Watson) #507798e733fb82] - (SEMVER-PATCH) Log when setting priority on a noop span (Igor Unanua) #50864b6a83a553] - (SEMVER-PATCH) K8s new scenarios (Roberto Montero) #5024b36ce05a16] - (SEMVER-MINOR) [DI] Implement PII redaction (Thomas Watson) #5053e2bee271f3] - (SEMVER-PATCH) Copy config_norm_rules.json from dd-go (Thomas Watson) #5073