Add macOS arm64 support #19193
Open
Add macOS arm64 support #19193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pythyu <Pythyu@users.noreply.github.com>
|
Changes in |
Pythyu
commented
Dec 26, 2024
| # Packages which must be built from source | ||
| always_build=() | ||
|
|
||
| if false && [[ "${DD_BUILD_PYTHON_VERSION}" == "3" ]]; then |
There was a problem hiding this comment.
Disabled the rebuild of confluent-kafka and librdkafka because some module doesn't support universal2 wheels and I didn't managed to force take the arm64 wheel instead of universal
There was a problem hiding this comment.
I don't think it is necessary for macOS m1 to have kerberos support at least for now since the main goal is to allow easier local building on our laptops
Pythyu
commented
Dec 26, 2024
| @@ -320,6 +327,7 @@ jobs: | |||
| - name: Create pull request | |||
| uses: peter-evans/create-pull-request@v5 | |||
| with: | |||
| base: pythyu/macos_arm_build | |||
There was a problem hiding this comment.
Hack I used to get .deps inside of this branch. Will be removed when merging
nubtron
approved these changes
Jan 13, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support to build arm64 macOS integrations, most of it is taken from original x64 macOS files and adapted for arm64
Motivation
Used on my hackathon project
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged