[INTPLAT-393] DDSaaS: Authorize.Net: Crawler Integration v1.0.0 #19216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grations-core into authorize_net-assets-v1.0.0
DhruvaPatel-crest
changed the title
buraizu
requested changes
Dec 24, 2024
There was a problem hiding this comment.
Thanks for the PR; I've left some minor feedback per our style guide and also for consistency.
I've also suggested breaking the Generate Login ID and Transaction Key in Authorize.Net section into two sub-sections for the Login ID and Transaction Key. As a general guideline, keeping lists of numbered steps to 8 or less is helpful for user engagement.
Let me know if you have any questions or feedback!
authorize_net/README.md
Outdated
| @@ -1,35 +1,60 @@ | |||
| # Authorize.Net | |||
|
|
|||
| ## Overview | |||
| [Authorize.Net][1] is a widely used payment gateway that allows businesses to accept secure payments through various channels, including online, mobile, and in-person transactions. Supporting a range of payment methods such as credit cards, e-checks, and digital wallets, it offers a versatile solution for merchants. The platform emphasizes security with features like encryption, tokenization, and PCI DSS compliance, while also providing advanced fraud detection tools. | |||
There was a problem hiding this comment.
Suggested change
| [Authorize.Net][1] is a widely used payment gateway that allows businesses to accept secure payments through various channels, including online, mobile, and in-person transactions. Supporting a range of payment methods such as credit cards, e-checks, and digital wallets, it offers a versatile solution for merchants. The platform emphasizes security with features like encryption, tokenization, and PCI DSS compliance, while also providing advanced fraud detection tools. | |
| [Authorize.Net][1] is a payment gateway that allows businesses to accept secure payments through various channels, including online, mobile, and in-person transactions. It supports a range of payment methods such as credit cards, e-checks, and digital wallets, and offers a versatile solution for merchants. The platform emphasizes security with features like encryption, tokenization, and PCI DSS compliance, while also providing advanced fraud detection tools. |
There was a problem hiding this comment.
Done changes as per suggestion.
authorize_net/README.md
Outdated
|
|
||
| Authorize.Net is a widely used payment gateway that allows businesses to accept secure payments through various channels, including online, mobile, and in-person transactions. Supporting a range of payment methods such as credit cards, e-checks, and digital wallets like Apple Pay and PayPal, it offers a versatile solution for merchants. The platform emphasizes security with features like encryption, tokenization, and PCI DSS compliance, while also providing advanced fraud detection tools | ||
| The Authorize.Net integration collects settled transaction logs and unsettled transaction metrics and sends it into Datadog for comprehensive analysis. |
There was a problem hiding this comment.
Suggested change
| The Authorize.Net integration collects settled transaction logs and unsettled transaction metrics and sends it into Datadog for comprehensive analysis. | |
| The Authorize.Net integration collects settled transaction logs and unsettled transaction metrics, and forwards them to Datadog for comprehensive analysis. |
There was a problem hiding this comment.
Done changes as per suggestion.
authorize_net/README.md
Outdated
| - For a production environment, visit [login.authorize.net][2]. | ||
| - For a sandbox environment, visit [sandbox.authorize.net][5]. | ||
| 2. Sign in to your Authorize.Net account with a user which has access to the **Account Administrator** role. | ||
| 3. Go to the Accounts > Security Settings > General Security Settings. |
There was a problem hiding this comment.
Suggested change
| 3. Go to the Accounts > Security Settings > General Security Settings. | |
| 3. Go to **Accounts > Security Settings > General Security Settings**. |
There was a problem hiding this comment.
Done changes as per suggestion.
authorize_net/README.md
Outdated
| - For a sandbox environment, visit [sandbox.authorize.net][5]. | ||
| 2. Sign in to your Authorize.Net account with a user which has access to the **Account Administrator** role. | ||
| 3. Go to the Accounts > Security Settings > General Security Settings. | ||
| 4. Click **API Credentials & Keys**, and get API Login ID. |
There was a problem hiding this comment.
Suggested change
| 4. Click **API Credentials & Keys**, and get API Login ID. | |
| 4. Click **API Credentials & Keys**. | |
| 5. Use the API Login ID as the `Login ID` value when you [connect your Authorize.Net account to Datadog](#connect-your-authorizenet-account-to-datadog). |
There was a problem hiding this comment.
Done changes as per suggestion.
authorize_net/README.md
Outdated
| 2. Sign in to your Authorize.Net account with a user which has access to the **Account Administrator** role. | ||
| 3. Go to the Accounts > Security Settings > General Security Settings. | ||
| 4. Click **API Credentials & Keys**, and get API Login ID. | ||
| 5. To get Transaction Key, on the same page click **New Transaction Key** and click **Submit**. |
There was a problem hiding this comment.
Suggested change
| 5. To get Transaction Key, on the same page click **New Transaction Key** and click **Submit**. | |
| 5. On the same page, click **New Transaction Key** and then click **Submit**. |
There was a problem hiding this comment.
Done changes as per suggestion.
|
|
||
| !!! Add list of steps to set up this integration !!! | ||
| 1. Visit the appropriate URL: |
There was a problem hiding this comment.
Suggested change
| 1. Visit the appropriate URL: | |
| #### Login ID | |
| 1. Visit the appropriate URL: |
There was a problem hiding this comment.
Done changes as per suggestion.
authorize_net/README.md
Outdated
| 2. Sign in to your Authorize.Net account with a user which has access to the **Account Administrator** role. | ||
| 3. Go to the Accounts > Security Settings > General Security Settings. | ||
| 4. Click **API Credentials & Keys**, and get API Login ID. | ||
| 5. To get Transaction Key, on the same page click **New Transaction Key** and click **Submit**. |
There was a problem hiding this comment.
Suggested change
| 5. To get Transaction Key, on the same page click **New Transaction Key** and click **Submit**. | |
| #### Transaction Key | |
| 1. On the same page, click **New Transaction Key** and then **Submit**. |
There was a problem hiding this comment.
Done changes as per suggestion.
authorize_net/README.md
Outdated
|
|
||
| |Parameters| Description | | ||
| |--------------------|------------------------------------------------------------------------------------------------| | ||
| |Login ID| Login ID for your Authorize.Net account. | |
There was a problem hiding this comment.
Suggested change
| |Login ID| Login ID for your Authorize.Net account. | | |
| |Login ID| API Login ID for your Authorize.Net account. | |
There was a problem hiding this comment.
Done changes as per suggestion.
authorize_net/metadata.csv
Outdated
Comment on lines
2
to
10
| authorize_net.unsettled_transaction.amount_by_account_type,count,,,,Contains total amount for unsettled transactions by account type,0,authorize_net,Total amount by account type,, | ||
| authorize_net.unsettled_transaction.amount_by_market_type,count,,,,Contains total amount for unsettled transactions by market type,0,authorize_net,Total amount by market type,, | ||
| authorize_net.unsettled_transaction.amount_by_product,count,,,,Contains total amount for unsettled transactions by product,0,authorize_net,Total amount by product,, | ||
| authorize_net.unsettled_transaction.amount_by_status,count,,,,Contains total amount for unsettled transactions by status,0,authorize_net,Total amount by status,, | ||
| authorize_net.unsettled_transaction.count_by_account_type,count,,,,Contains total number of unsettled transactions by account type,0,authorize_net,Count by account type,, | ||
| authorize_net.unsettled_transaction.count_by_market_type,count,,,,Contains total number of unsettled transactions by market type,0,authorize_net,Count by market type,, | ||
| authorize_net.unsettled_transaction.count_by_product,count,,,,Contains total number of unsettled transactions by product,0,authorize_net,Count by product,, | ||
| authorize_net.unsettled_transaction.count_by_status,count,,,,Contains total number of unsettled transactions by status,0,authorize_net,Count by status,, | ||
| authorize_net.unsettled_transaction.total_unsettled_transactions,count,,,,Contains total number of unsettled transactions,0,authorize_net,Total unsettled transactions,, |
There was a problem hiding this comment.
Suggested change
| authorize_net.unsettled_transaction.amount_by_account_type,count,,,,Contains total amount for unsettled transactions by account type,0,authorize_net,Total amount by account type,, | |
| authorize_net.unsettled_transaction.amount_by_market_type,count,,,,Contains total amount for unsettled transactions by market type,0,authorize_net,Total amount by market type,, | |
| authorize_net.unsettled_transaction.amount_by_product,count,,,,Contains total amount for unsettled transactions by product,0,authorize_net,Total amount by product,, | |
| authorize_net.unsettled_transaction.amount_by_status,count,,,,Contains total amount for unsettled transactions by status,0,authorize_net,Total amount by status,, | |
| authorize_net.unsettled_transaction.count_by_account_type,count,,,,Contains total number of unsettled transactions by account type,0,authorize_net,Count by account type,, | |
| authorize_net.unsettled_transaction.count_by_market_type,count,,,,Contains total number of unsettled transactions by market type,0,authorize_net,Count by market type,, | |
| authorize_net.unsettled_transaction.count_by_product,count,,,,Contains total number of unsettled transactions by product,0,authorize_net,Count by product,, | |
| authorize_net.unsettled_transaction.count_by_status,count,,,,Contains total number of unsettled transactions by status,0,authorize_net,Count by status,, | |
| authorize_net.unsettled_transaction.total_unsettled_transactions,count,,,,Contains total number of unsettled transactions,0,authorize_net,Total unsettled transactions,, | |
| authorize_net.unsettled_transaction.amount_by_account_type,count,,,,Total amount of unsettled transactions by account type,0,authorize_net,Total amount by account type,, | |
| authorize_net.unsettled_transaction.amount_by_market_type,count,,,,Total amount of unsettled transactions by market type,0,authorize_net,Total amount by market type,, | |
| authorize_net.unsettled_transaction.amount_by_product,count,,,,Total amount of unsettled transactions by product,0,authorize_net,Total amount by product,, | |
| authorize_net.unsettled_transaction.amount_by_status,count,,,,Total amount of unsettled transactions by status,0,authorize_net,Total amount by status,, | |
| authorize_net.unsettled_transaction.count_by_account_type,count,,,,Total number of unsettled transactions by account type,0,authorize_net,Count by account type,, | |
| authorize_net.unsettled_transaction.count_by_market_type,count,,,,Total number of unsettled transactions by market type,0,authorize_net,Count by market type,, | |
| authorize_net.unsettled_transaction.count_by_product,count,,,,Total number of unsettled transactions by product,0,authorize_net,Count by product,, | |
| authorize_net.unsettled_transaction.count_by_status,count,,,,Total number of unsettled transactions by status,0,authorize_net,Count by status,, | |
| authorize_net.unsettled_transaction.total_unsettled_transactions,count,,,,Total number of unsettled transactions,0,authorize_net,Total unsettled transactions,, |
There was a problem hiding this comment.
Done changes as per suggestion.
|
|
||
| ### Metrics | ||
|
|
||
| The Authorize.Net integration collects and forward metrics to Datadog. | ||
| The Authorize.Net integration collects and forwards unsettled transaction metrics to Datadog. |
There was a problem hiding this comment.
Is it expected that the metrics in metadata.csv will be displayed here?
There was a problem hiding this comment.
Yes, we are following this standard to list all the metrics ingested by this integration in the integration document.
datadog-assets
bot
added
docs/requested-changes
and removed
docs/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is an initial release PR of Authorize.Net integration including all the required assets.
Motivation
Crawler code for this integration has been committed in its respective repo
Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
Samples for the pipeline review would also be shared separately with the required teams.
Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behavior.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged