Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NIM dashboard and docs preview message #19239

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add NIM dashboard and docs preview message #19239

merged 2 commits into from
Jan 10, 2025

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Dec 10, 2024 •
edited
Loading

What does this PR do?

This PR adds in the preview notifications in the tile and public facing documentation as well

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@Kyle-Neale Kyle-Neale marked this pull request as ready for review December 10, 2024 14:18
@Kyle-Neale Kyle-Neale requested review from a team as code owners December 10, 2024 14:18
HadhemiDD
HadhemiDD previously approved these changes Dec 10, 2024
View reviewed changes
@Kyle-Neale Kyle-Neale enabled auto-merge December 10, 2024 14:25
@Kyle-Neale Kyle-Neale added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 10, 2024
neko-dd
neko-dd reviewed Dec 10, 2024
View reviewed changes
nvidia_nim/README.md Outdated Show resolved Hide resolved
nvidia_nim/assets/dashboards/nvidia_nim_overview.json Outdated Show resolved Hide resolved
@Kyle-Neale @neko-dd
Apply suggestions from code review
f349d22 
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
@Kyle-Neale Kyle-Neale enabled auto-merge January 10, 2025 14:43
@Kyle-Neale Kyle-Neale added this pull request to the merge queue Jan 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (37a3772) to head (f349d22).
Report is 89 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Merged via the queue into master with commit fff0a19 Jan 10, 2025
34 checks passed
@Kyle-Neale Kyle-Neale deleted the kyle.neale/nvidia-nim-add-preview branch January 10, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neko-dd neko-dd neko-dd left review comments

@HadhemiDD HadhemiDD HadhemiDD approved these changes

Assignees
No one assigned
Labels
agent/approved docs/review-requested ecosystems/review-requested product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kyle-Neale @HadhemiDD @neko-dd