-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs for Quarkus #19293
Add logs for Quarkus #19293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall things look good to me, I only had one minor request for the grok rule.
Note: do not be surprised, since we are under the EOY production freeze, approval won't happen before Thursday.
Co-authored-by: Bruno Renier <67916268+brunorenier@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for logs!
* Add logs for Quarkus * fix validations * Update quarkus/assets/logs/quarkus.yaml Co-authored-by: Bruno Renier <67916268+brunorenier@users.noreply.github.com> --------- Co-authored-by: Bruno Renier <67916268+brunorenier@users.noreply.github.com> eb5fa08
What does this PR do?
Here's the logs-core ticket: https://datadoghq.atlassian.net/browse/LOI-360
Note: I'll add documentation for how to enable logs when I write the Readme (later today). Keeping that separate to limit reviewer load.
Here's a screenshot of the pipeline in action:
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged