Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supabase integration #19307

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Dec 25, 2024

What does this PR do?

Supabase implementation.

  • Just python code and tests

Separate PRs will be made for:

  • Docs and metadata entries
  • Dashboard
  • Logs
  • Saved Views
  • Process Signature
  • Recommended Monitors

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 93.97590% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.63%. Comparing base (aa9bd4e) to head (f7adf05).
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
supabase 93.97% <93.97%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale marked this pull request as ready for review December 25, 2024 12:26
@Kyle-Neale Kyle-Neale requested review from a team as code owners December 25, 2024 12:26
# (C) Datadog, Inc. 2024-present
# All rights reserved
# Licensed under a 3-clause BSD style license (see LICENSE)
from datadog_checks.base.checks.openmetrics.v2.metrics import DEFAULT_GO_METRICS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'd say we should do differently here is to change this metric:

'process_start_time_seconds': 'process.start_time.seconds',

We should make it an elapsed time metric. I can do that. But then we'd have to make a release and bump the min base package in this check. The easier way maybe to overwrite the metric in your metric list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants