Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused scandir dependency #19380

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Drop unused scandir dependency #19380

merged 5 commits into from
Jan 13, 2025

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Jan 13, 2025

What does this PR do?

Motivation

We were only keeping this for Python 2 compatibility. We missed because this was implicit.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@iliakur iliakur requested a review from a team as a code owner January 13, 2025 11:45
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (0ac7e8f) to head (7bad66d).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
directory 96.88% <100.00%> (+0.42%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@iliakur iliakur added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit c32b251 Jan 13, 2025
41 checks passed
@iliakur iliakur deleted the ik/drop-unused-scandir branch January 13, 2025 13:26
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
* Drop unused scandir dependency

* add changelog

* update agent requirements

* fix changelog number

* fix license file c32b251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants