Move performance namespace inside view

DataDog · Jan 13, 2025 · 5c0ca10 · 5c0ca10
1 parent 61e86d1
commit 5c0ca10
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 49 deletions.
diff --git a/lib/cjs/generated/rum.d.ts b/lib/cjs/generated/rum.d.ts
@@ -973,6 +973,10 @@ export declare type RumViewEvent = CommonProperties & ViewContainerSchema & {
          * The JavaScript refresh rate for React Native
          */
         js_refresh_rate?: RumPerfMetric;
+        /**
+         * Performance data. (Web Vitals, etc.)
+         */
+        performance?: ViewPerformanceData;
         [k: string]: unknown;
     };
     /**
@@ -1085,10 +1089,6 @@ export declare type RumViewEvent = CommonProperties & ViewContainerSchema & {
         };
         [k: string]: unknown;
     };
-    /**
-     * Performance data. (Web Vitals, etc.)
-     */
-    performance?: ViewPerformanceData;
     [k: string]: unknown;
 };
 /**

diff --git a/lib/esm/generated/rum.d.ts b/lib/esm/generated/rum.d.ts
@@ -973,6 +973,10 @@ export declare type RumViewEvent = CommonProperties & ViewContainerSchema & {
          * The JavaScript refresh rate for React Native
          */
         js_refresh_rate?: RumPerfMetric;
+        /**
+         * Performance data. (Web Vitals, etc.)
+         */
+        performance?: ViewPerformanceData;
         [k: string]: unknown;
     };
     /**
@@ -1085,10 +1089,6 @@ export declare type RumViewEvent = CommonProperties & ViewContainerSchema & {
         };
         [k: string]: unknown;
     };
-    /**
-     * Performance data. (Web Vitals, etc.)
-     */
-    performance?: ViewPerformanceData;
     [k: string]: unknown;
 };
 /**

diff --git a/samples/rum-events/view.json b/samples/rum-events/view.json
@@ -56,7 +56,43 @@
     "in_foreground_periods": [
       { "start": 1345678, "duration": 67 },
       { "start": 1645678, "duration": 67 }
-    ]
+    ],
+    "performance": {
+      "cls": {
+        "score": 0.1,
+        "timestamp": 2000,
+        "target_selector": "#foo",
+        "previous_rect": {
+          "x": 0,
+          "y": 0,
+          "width": 0,
+          "height": 0
+        },
+        "current_rect": {
+          "x": 0,
+          "y": 0,
+          "width": 0,
+          "height": 0
+        }
+      },
+      "fcp": {
+        "timestamp": 420725000
+      },
+      "fid": {
+        "duration": 20000000,
+        "timestamp": 20000000,
+        "target_selector": "#foo"
+      },
+      "inp": {
+        "duration": 20000000,
+        "timestamp": 20000000,
+        "target_selector": "#foo"
+      },
+      "lcp": {
+        "timestamp": 20000000,
+        "target_selector": "#foo"
+      }
+    }
   },
   "_dd": {
     "document_version": 9,
@@ -99,41 +135,5 @@
   },
   "privacy": {
     "replay_level": "mask"
-  },
-  "performance": {
-    "cls": {
-      "score": 0.1,
-      "timestamp": 2000,
-      "target_selector": "#foo",
-      "previous_rect": {
-        "x": 0,
-        "y": 0,
-        "width": 0,
-        "height": 0
-      },
-      "current_rect": {
-        "x": 0,
-        "y": 0,
-        "width": 0,
-        "height": 0
-      }
-    },
-    "fcp": {
-      "timestamp": 420725000
-    },
-    "fid": {
-      "duration": 20000000,
-      "timestamp": 20000000,
-      "target_selector": "#foo"
-    },
-    "inp": {
-      "duration": 20000000,
-      "timestamp": 20000000,
-      "target_selector": "#foo"
-    },
-    "lcp": {
-      "timestamp": 20000000,
-      "target_selector": "#foo"
-    }
   }
 }
diff --git a/schemas/rum/view-schema.json b/schemas/rum/view-schema.json
@@ -358,6 +358,10 @@
             "js_refresh_rate": {
               "description": "The JavaScript refresh rate for React Native",
               "allOf": [{ "$ref": "_perf-metric-schema.json" }]
+            },
+            "performance": {
+              "description": "Performance data. (Web Vitals, etc.)",
+              "allOf": [{ "$ref": "_view-performance-schema.json" }]
             }
           },
           "readOnly": true
@@ -508,10 +512,6 @@
               "readOnly": true
             }
           }
-        },
-        "performance": {
-          "description": "Performance data. (Web Vitals, etc.)",
-          "allOf": [{ "$ref": "_view-performance-schema.json" }]
         }
       }
     }